Issue 10836253: Extensions Docs Server: memcache_file_system fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10836253: Extensions Docs Server: memcache_file_system fix (Closed)

Created:
8 years, 4 months ago by cduvall

Modified:
8 years, 4 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Extensions Docs Server: memcache_file_system fix File reads should be cached forever. BUG=140262 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151583

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/common/extensions/docs/server2/memcache_file_system.py	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

8 years, 4 months ago (2012-08-14 22:19:47 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10836253/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/memcache_file_system.py (right):

https://chromiumcodereview.appspot.com/10836253/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/memcache_file_system.py:63: time=0)
what was it before?

but cool, add a commet like "cache forever" because that isn't immediately
obvious.

Expand Messages | Collapse Messages