chrome/common/extensions/docs/server2/memcache_file_system.py - Issue 10836253: Extensions Docs Server: memcache_file_system fix

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/server2/memcache_file_system.py

Issue 10836253: Extensions Docs Server: memcache_file_system fix (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from file_system import FileSystem	5 from file_system import FileSystem

6 from future import Future	6 from future import Future

7 import appengine_memcache as memcache	7 import appengine_memcache as memcache

8	8

9 class MemcacheFileSystem(FileSystem):	9 class MemcacheFileSystem(FileSystem):

10 """FileSystem implementation which memcaches the results of Read.	10 """FileSystem implementation which memcaches the results of Read.

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 result[path] = data	52 result[path] = data

53 if uncached:	53 if uncached:

54 # TODO(cduvall): if there are uncached items we should return an	54 # TODO(cduvall): if there are uncached items we should return an

55 # asynchronous future. http://crbug.com/142013	55 # asynchronous future. http://crbug.com/142013

56 new_items = self._file_system.Read(uncached, binary=binary).Get()	56 new_items = self._file_system.Read(uncached, binary=binary).Get()

57 for item in new_items:	57 for item in new_items:

58 version = self.Stat(item).version	58 version = self.Stat(item).version

59 value = new_items[item]	59 value = new_items[item]

60 self._memcache.Set(item,	60 self._memcache.Set(item,

61 (value, version),	61 (value, version),

62 memcache.MEMCACHE_FILE_SYSTEM_READ)	62 memcache.MEMCACHE_FILE_SYSTEM_READ,

	63 time=0)
	not at google - send to devlin 2012/08/14 22:19:47 what was it before? but cool, add a commet like " what was it before? but cool, add a commet like "cache forever" because that isn't immediately obvious.
63 result[item] = value	64 result[item] = value

64 return Future(value=result)	65 return Future(value=result)

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »