Remove BrowserList::GetLastActive calls from window_sizer.cc et al.

Remove BrowserList::GetLastActive calls from window_sizer.cc et al.

BUG=129187
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151665

[MAD, 2012-08-13 21:25:10]

A few initial drive-by comments...

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/brow...
File chrome/browser/ui/browser_finder.cc (right):

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/brow...
chrome/browser/ui/browser_finder.cc:185: if (browser_list_impl) {
no need for {}

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/wind...
File chrome/browser/ui/window_sizer/window_sizer_gtk.cc (right):

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/wind...
chrome/browser/ui/window_sizer/window_sizer_gtk.cc:25: DCHECK(browser);
???

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/wind...
File chrome/browser/ui/window_sizer/window_sizer_mac.mm (right):

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/wind...
chrome/browser/ui/window_sizer/window_sizer_mac.mm:25: if (Browser* b =
browser::FindLastActiveWithHostDesktopType(type)) {
I would change b for browser.

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/wind...
File chrome/browser/ui/window_sizer/window_sizer_win.cc (right):

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/wind...
chrome/browser/ui/window_sizer/window_sizer_win.cc:23: if (Browser* b =
browser::FindLastActiveWithHostDesktopType(type)) {
b -> browser

[robertshield, 2012-08-13 21:37:41]

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/brow...
File chrome/browser/ui/browser_finder.cc (right):

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/brow...
chrome/browser/ui/browser_finder.cc:185: if (browser_list_impl) {
On 2012/08/13 21:25:10, MAD wrote:
> no need for {}

Done.

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/wind...
File chrome/browser/ui/window_sizer/window_sizer_gtk.cc (right):

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/wind...
chrome/browser/ui/window_sizer/window_sizer_gtk.cc:25: DCHECK(browser);
On 2012/08/13 21:25:10, MAD wrote:
> ???

Heh, left over cruft. Removed.

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/wind...
File chrome/browser/ui/window_sizer/window_sizer_mac.mm (right):

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/wind...
chrome/browser/ui/window_sizer/window_sizer_mac.mm:25: if (Browser* b =
browser::FindLastActiveWithHostDesktopType(type)) {
On 2012/08/13 21:25:10, MAD wrote:
> I would change b for browser.

Done.

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/wind...
File chrome/browser/ui/window_sizer/window_sizer_win.cc (right):

https://chromiumcodereview.appspot.com/10836218/diff/1/chrome/browser/ui/wind...
chrome/browser/ui/window_sizer/window_sizer_win.cc:23: if (Browser* b =
browser::FindLastActiveWithHostDesktopType(type)) {
On 2012/08/13 21:25:10, MAD wrote:
> b -> browser

Done.

[robertshield, 2012-08-14 14:45:53]

PTAL

[Ben Goodger (Google), 2012-08-14 15:22:56]

lgtm

[commit-bot: I haz the power, 2012-08-14 15:53:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/10836218/9002

[commit-bot: I haz the power, 2012-08-14 18:07:36]

Try job failure for 10836218-9002 (retry) on win_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-15 02:05:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/10836218/9002

[commit-bot: I haz the power, 2012-08-15 06:18:51]

Change committed as 151665