Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: chrome/browser/ui/window_sizer/window_sizer_mac.mm

Issue 10836218: Remove BrowserList::GetLastActive calls from window_sizer.cc et al. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/window_sizer/window_sizer.h" 5 #include "chrome/browser/ui/window_sizer/window_sizer.h"
6 6
7 #import <Cocoa/Cocoa.h> 7 #import <Cocoa/Cocoa.h>
8 8
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/browser_list.h" 10 #include "chrome/browser/ui/browser_finder.h"
11 #include "chrome/browser/ui/browser_window.h" 11 #include "chrome/browser/ui/browser_window.h"
12 #include "chrome/browser/ui/host_desktop.h"
12 13
13 // How much horizontal and vertical offset there is between newly 14 // How much horizontal and vertical offset there is between newly
14 // opened windows. 15 // opened windows.
15 const int WindowSizer::kWindowTilePixels = 22; 16 const int WindowSizer::kWindowTilePixels = 22;
16 17
17 // static 18 // static
18 gfx::Point WindowSizer::GetDefaultPopupOrigin(const gfx::Size& size) { 19 gfx::Point WindowSizer::GetDefaultPopupOrigin(const gfx::Size& size,
20 chrome::HostDesktopType type) {
19 NSRect work_area = [[NSScreen mainScreen] visibleFrame]; 21 NSRect work_area = [[NSScreen mainScreen] visibleFrame];
20 NSRect main_area = [[[NSScreen screens] objectAtIndex:0] frame]; 22 NSRect main_area = [[[NSScreen screens] objectAtIndex:0] frame];
21 NSPoint corner = NSMakePoint(NSMinX(work_area), NSMaxY(work_area)); 23 NSPoint corner = NSMakePoint(NSMinX(work_area), NSMaxY(work_area));
22 24
23 if (Browser* b = BrowserList::GetLastActive()) { 25 if (Browser* b = browser::FindLastActiveWithHostDesktopType(type)) {
MAD 2012/08/13 21:25:10 I would change b for browser.
robertshield 2012/08/13 21:37:41 Done.
24 NSWindow* window = b->window()->GetNativeWindow(); 26 NSWindow* window = b->window()->GetNativeWindow();
25 NSRect window_frame = [window frame]; 27 NSRect window_frame = [window frame];
26 28
27 // Limit to not overflow the work area right and bottom edges. 29 // Limit to not overflow the work area right and bottom edges.
28 NSPoint limit = NSMakePoint( 30 NSPoint limit = NSMakePoint(
29 std::min(NSMinX(window_frame) + kWindowTilePixels, 31 std::min(NSMinX(window_frame) + kWindowTilePixels,
30 NSMaxX(work_area) - size.width()), 32 NSMaxX(work_area) - size.width()),
31 std::max(NSMaxY(window_frame) - kWindowTilePixels, 33 std::max(NSMaxY(window_frame) - kWindowTilePixels,
32 NSMinY(work_area) + size.height())); 34 NSMinY(work_area) + size.height()));
33 35
34 // Adjust corner to now overflow the work area left and top edges, so 36 // Adjust corner to now overflow the work area left and top edges, so
35 // that if a popup does not fit the title-bar is remains visible. 37 // that if a popup does not fit the title-bar is remains visible.
36 corner = NSMakePoint(std::max(corner.x, limit.x), 38 corner = NSMakePoint(std::max(corner.x, limit.x),
37 std::min(corner.y, limit.y)); 39 std::min(corner.y, limit.y));
38 } 40 }
39 41
40 return gfx::Point(corner.x, NSHeight(main_area) - corner.y); 42 return gfx::Point(corner.x, NSHeight(main_area) - corner.y);
41 } 43 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698