Issue 10836161: Fix the browser test DownloadExtensionTest_FileIcon_Active crash which started occurring after my c…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10836161: Fix the browser test DownloadExtensionTest_FileIcon_Active crash which started occurring after my c… (Closed)

Created:
8 years, 4 months ago by ananta

Modified:
8 years, 4 months ago

Reviewers:
asanka

CC:
chromium-reviews, rdsmith+dwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix the browser test DownloadExtensionTest_FileIcon_Active crash which started occurring after my change 150597 to send out Windows 8 metro notifications when downloads complete. Reason for the crash:- We were not unsubscribing from the DownloadItem object when it was completed and instead doing it when the download manager was going away. At that point the object was already deleted. BUG=133109 TBR=asanka Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150625

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	chrome/browser/download/download_completion_observer_win.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages