Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: chrome/browser/download/download_completion_observer_win.cc

Issue 10836161: Fix the browser test DownloadExtensionTest_FileIcon_Active crash which started occurring after my c… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_completion_observer_win.cc
===================================================================
--- chrome/browser/download/download_completion_observer_win.cc (revision 150599)
+++ chrome/browser/download/download_completion_observer_win.cc (working copy)
@@ -44,12 +44,10 @@
}
void DownloadCompletionObserver::OnDownloadUpdated(DownloadItem* download) {
- if (!base::win::IsMetroProcess())
- return;
-
switch (download->GetState()) {
case DownloadItem::COMPLETE: {
- if (!download->GetOpenWhenComplete() &&
+ if (base::win::IsMetroProcess() &&
+ !download->GetOpenWhenComplete() &&
!download->ShouldOpenFileBasedOnExtension() &&
!download->IsTemporary() &&
!download->GetAutoOpened()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698