Issue 10836148: Don't print the callstack in forked browser test processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10836148: Don't print the callstack in forked browser test processes. (Closed)

Created:
8 years, 4 months ago by jam

Modified:
8 years, 4 months ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Don't print the callstack in forked browser test processes. This may allocate memory or try to acquire OS locks which may already be locked from the parent process. This was happening because there's a race condition where the browser process forks a process and shuts it down very soon after, before it calls exec*. BUG=141302, 139209, 36678 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150603

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : sync #

Patch Set 5 : simplify #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -51 lines)			Patch
M	chrome/test/base/in_process_browser_test.h	View	1 2 3 4	2 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/test/base/in_process_browser_test.cc	View	1 2 3 4	3 chunks	+0 lines, -19 lines	0 comments	Download
M	content/test/browser_test_base.h	View	1 2 3 4	2 chunks	+12 lines, -0 lines	0 comments	Download
M	content/test/browser_test_base.cc	View	1 2 3 4	3 chunks	+31 lines, -0 lines	0 comments	Download
M	content/test/content_browser_test.cc	View	1 2 3 4	3 chunks	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mihai Parparita -not on Chrome

LGTM Does this behave better in your VM tests?

8 years, 4 months ago (2012-08-08 18:59:43 UTC) #2

jam

8 years, 4 months ago (2012-08-08 19:02:20 UTC) #3

On 2012/08/08 18:59:43, Mihai Parparita wrote:
> LGTM
> 
> Does this behave better in your VM tests?

yep, I haven't been able to repro a hang so far in 40 minutes of running it.
I'll continue running it till the trybots are done to make sure.

Looking at all the other callstacks that I got from before, by inspection this
would also solve them.

Expand Messages | Collapse Messages