Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: chrome/test/base/in_process_browser_test.cc

Issue 10836148: Don't print the callstack in forked browser test processes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: simplify Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/in_process_browser_test.h ('k') | content/test/browser_test_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/in_process_browser_test.cc
===================================================================
--- chrome/test/base/in_process_browser_test.cc (revision 150562)
+++ chrome/test/base/in_process_browser_test.cc (working copy)
@@ -7,7 +7,6 @@
#include "base/auto_reset.h"
#include "base/bind.h"
#include "base/command_line.h"
-#include "base/debug/stack_trace.h"
#include "base/file_path.h"
#include "base/file_util.h"
#include "base/path_service.h"
@@ -60,9 +59,6 @@
InProcessBrowserTest::InProcessBrowserTest()
: browser_(NULL)
-#if defined(OS_POSIX)
- , handle_sigterm_(true)
-#endif
#if defined(OS_MACOSX)
, autorelease_pool_(NULL)
#endif // OS_MACOSX
@@ -316,22 +312,7 @@
}
#endif
-#if defined(OS_POSIX)
-// On SIGTERM (sent by the runner on timeouts), dump a stack trace (to make
-// debugging easier) and also exit with a known error code (so that the test
-// framework considers this a failure -- http://crbug.com/57578).
-static void DumpStackTraceSignalHandler(int signal) {
- base::debug::StackTrace().PrintBacktrace();
- _exit(128 + signal);
-}
-#endif // defined(OS_POSIX)
-
void InProcessBrowserTest::RunTestOnMainThreadLoop() {
-#if defined(OS_POSIX)
- if (handle_sigterm_)
- signal(SIGTERM, DumpStackTraceSignalHandler);
-#endif // defined(OS_POSIX)
-
// Pump startup related events.
content::RunAllPendingInMessageLoop();
« no previous file with comments | « chrome/test/base/in_process_browser_test.h ('k') | content/test/browser_test_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698