Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Issue 10836120: Revert 150124 - Implement SHA-256 fingerprint support. (Closed)

Created:
8 years, 4 months ago by Dmitry Titov
Modified:
8 years, 4 months ago
Reviewers:
palmer
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, darin-cc_chromium.org, mmenke, Jeffrey Yasskin
Visibility:
Public.

Description

Revert 150124 - Implement SHA-256 fingerprint support. The HTTP-based Public Key Pinning Internet Draft (tools.ietf.org/html/draft-ietf-websec-key-pinning) requires this. Per wtc, give the *Fingeprint* types more meaningful *HashValue* names. Cleaning up lint along the way. This CL reverts 149268, which reverted 149261 the previous version of this CL. It includes a fix to the compile problem that necessitated 149268. BUG=117914 TEST=net_unittests, unit_tests TransportSecurityPersisterTest Review URL: https://chromiumcodereview.appspot.com/10836062 TBR=palmer@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150166

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -577 lines) Patch
M chrome/browser/net/transport_security_persister.cc View 1 chunk +9 lines, -23 lines 0 comments Download
M chrome/browser/net/transport_security_persister_unittest.cc View 5 chunks +15 lines, -28 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 2 chunks +6 lines, -20 lines 0 comments Download
M net/base/cert_test_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/cert_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/cert_verify_proc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/cert_verify_proc.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M net/base/cert_verify_proc_mac.cc View 4 chunks +5 lines, -14 lines 0 comments Download
M net/base/cert_verify_proc_nss.cc View 3 chunks +8 lines, -25 lines 0 comments Download
M net/base/cert_verify_proc_openssl.cc View 3 chunks +4 lines, -14 lines 0 comments Download
M net/base/cert_verify_proc_unittest.cc View 3 chunks +9 lines, -15 lines 0 comments Download
M net/base/cert_verify_proc_win.cc View 5 chunks +6 lines, -15 lines 0 comments Download
M net/base/cert_verify_result.h View 1 chunk +4 lines, -9 lines 0 comments Download
M net/base/cert_verify_result.cc View 1 chunk +1 line, -7 lines 0 comments Download
M net/base/ev_root_ca_metadata.h View 5 chunks +8 lines, -9 lines 0 comments Download
M net/base/ev_root_ca_metadata.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M net/base/ev_root_ca_metadata_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/multi_threaded_cert_verifier.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/base/multi_threaded_cert_verifier_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/ssl_info.h View 1 chunk +2 lines, -5 lines 0 comments Download
M net/base/ssl_info.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M net/base/transport_security_state.h View 4 chunks +6 lines, -7 lines 0 comments Download
M net/base/transport_security_state.cc View 10 chunks +60 lines, -101 lines 0 comments Download
M net/base/transport_security_state_unittest.cc View 14 chunks +33 lines, -85 lines 0 comments Download
M net/base/x509_cert_types.h View 3 chunks +13 lines, -115 lines 1 comment Download
M net/base/x509_cert_types.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/x509_certificate.h View 3 chunks +6 lines, -6 lines 0 comments Download
M net/base/x509_certificate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/x509_certificate_mac.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/base/x509_certificate_nss.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/base/x509_certificate_openssl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/base/x509_certificate_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/base/x509_certificate_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_nss.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Titov
8 years, 4 months ago (2012-08-06 23:08:49 UTC) #1
Jeffrey Yasskin
https://chromiumcodereview.appspot.com/10836120/diff/1/net/base/x509_cert_types.h File net/base/x509_cert_types.h (left): https://chromiumcodereview.appspot.com/10836120/diff/1/net/base/x509_cert_types.h#oldcode100 net/base/x509_cert_types.h:100: return 0; For Chris: I suspect that returning "sizeof(fingerprint)" ...
8 years, 4 months ago (2012-08-06 23:36:33 UTC) #2
palmer
8 years, 4 months ago (2012-08-06 23:38:32 UTC) #3
> net/base/x509_cert_types.h:100: return 0;
> For Chris: I suspect that returning "sizeof(fingerprint)" here instead of 0
will
> fix the problem. I'd be interested to hear if it doesn't.

Thank you Jeffrey! I'm trying that (well, something substantially like it) now:

https://chromiumcodereview.appspot.com/10825211/

Powered by Google App Engine
This is Rietveld 408576698