Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 10836062: Implement SHA-256 fingerprint support (Closed)

Created:
8 years, 4 months ago by palmer
Modified:
8 years, 4 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, darin-cc_chromium.org, mmenke
Visibility:
Public.

Description

Implement SHA-256 fingerprint support. The HTTP-based Public Key Pinning Internet Draft (tools.ietf.org/html/draft-ietf-websec-key-pinning) requires this. Per wtc, give the *Fingeprint* types more meaningful *HashValue* names. Cleaning up lint along the way. This CL reverts 149268, which reverted 149261 the previous version of this CL. It includes a fix to the compile problem that necessitated 149268. BUG=117914 TEST=net_unittests, unit_tests TransportSecurityPersisterTest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150124

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+577 lines, -259 lines) Patch
M chrome/browser/net/transport_security_persister.cc View 1 2 1 chunk +23 lines, -9 lines 0 comments Download
M chrome/browser/net/transport_security_persister_unittest.cc View 1 2 5 chunks +28 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 2 2 chunks +20 lines, -6 lines 0 comments Download
M net/base/cert_test_util.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/cert_test_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/base/cert_verify_proc.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/cert_verify_proc.cc View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M net/base/cert_verify_proc_mac.cc View 1 2 4 chunks +14 lines, -5 lines 0 comments Download
M net/base/cert_verify_proc_nss.cc View 1 2 3 chunks +25 lines, -8 lines 0 comments Download
M net/base/cert_verify_proc_openssl.cc View 1 2 3 chunks +14 lines, -4 lines 0 comments Download
M net/base/cert_verify_proc_unittest.cc View 1 2 3 chunks +15 lines, -9 lines 0 comments Download
M net/base/cert_verify_proc_win.cc View 1 2 5 chunks +15 lines, -6 lines 0 comments Download
M net/base/cert_verify_result.h View 1 2 1 chunk +9 lines, -4 lines 0 comments Download
M net/base/cert_verify_result.cc View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M net/base/ev_root_ca_metadata.h View 1 2 5 chunks +9 lines, -8 lines 0 comments Download
M net/base/ev_root_ca_metadata.cc View 1 2 9 chunks +10 lines, -10 lines 0 comments Download
M net/base/ev_root_ca_metadata_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/multi_threaded_cert_verifier.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M net/base/multi_threaded_cert_verifier_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/ssl_info.h View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M net/base/ssl_info.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M net/base/transport_security_state.h View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M net/base/transport_security_state.cc View 1 2 10 chunks +101 lines, -60 lines 0 comments Download
M net/base/transport_security_state_unittest.cc View 1 2 14 chunks +85 lines, -33 lines 0 comments Download
M net/base/x509_cert_types.h View 1 2 3 chunks +115 lines, -13 lines 0 comments Download
M net/base/x509_cert_types.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/base/x509_certificate.h View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M net/base/x509_certificate.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/x509_certificate_mac.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M net/base/x509_certificate_nss.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M net/base/x509_certificate_openssl.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M net/base/x509_certificate_unittest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M net/base/x509_certificate_win.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_nss.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 2 2 chunks +10 lines, -6 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698