Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 10836069: Revert 149576 - gdata: Make WeakPtrFactory the last parameter (Closed)

Created:
8 years, 4 months ago by satorux1
Modified:
8 years, 4 months ago
Reviewers:
satorux1
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 149576 - gdata: Make WeakPtrFactory the last parameter Broke RemoteFileSystemExtensionApiTest.RemoteMountPoint Remove WeakPtr members in favor of WeakPtrFactory::GetWeakPtr() Along the way, copy derat's comment from ContactDatabase on this matter. Wez on [chromium-dev] Weak ptrs for derived types? You need to be similarly careful to have WeakPtrFactory appear after any fields that its WeakPtrs may be used to access if you follow that pattern instead. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10837061 TBR=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149582

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -136 lines) Patch
M chrome/browser/chromeos/gdata/gdata_auth_service.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_auth_service.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_cache.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_cache.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_download_observer.h View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.cc View 83 chunks +88 lines, -93 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operation_runner.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operation_runner.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_sync_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_uploader.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_uploader.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/gdata/operations_base.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
satorux1
8 years, 4 months ago (2012-08-02 06:34:12 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698