Extension Docs Server: Include a list of samples used in the api reference page.

Extension Docs Server: Include a list of samples used in the api reference page.

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149690

[chebert, 2012-07-26 20:34:19]

Ignore the changes to the tests for now.

[chebert, 2012-07-26 20:36:39]

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/handlebar_dict_generator.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/handlebar_dict_generator.py:73: if
api_name == api['name'].split('.', 2)[1]:
not sure if this is "safe"

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/handlebar_dict_generator_test.py
(right):

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/handlebar_dict_generator_test.py:28: print
json.dumps(gen.Generate(), indent=2)
ignore.

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/template_data_source.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/template_data_source.py:92:
self._api_data_source.samples = self._samples_data_source.get(samples_key)
I can combine these? Not sure.

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/template_data_source_test.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/template_data_source_test.py:28:
self._fake_api_data_source = _FakeApiDataSource()
ignore.

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/templates/private/sample.html
(right):

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/templates/private/sample.html:1: {{name}}
ignore

[cduvall, 2012-07-26 22:04:24]

http://codereview.chromium.org/10835012/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/server2/api_data_source.py (right):

http://codereview.chromium.org/10835012/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/api_data_source.py:19: def __init__(self,
cache_builder, base_path):
See comment in TDS about factory so this can take samples in its constructor.

http://codereview.chromium.org/10835012/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/server2/handlebar_dict_generator.py (right):

http://codereview.chromium.org/10835012/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/handlebar_dict_generator.py:73: if
api_name == api['name'].split('.', 2)[1]:
On 2012/07/26 20:36:39, chebert wrote:
> not sure if this is "safe"

I would just do:
if api_name in api['name']:

http://codereview.chromium.org/10835012/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/server2/template_data_source.py (right):

http://codereview.chromium.org/10835012/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/template_data_source.py:92:
self._api_data_source.samples = self._samples_data_source.get(samples_key)
On 2012/07/26 20:36:39, chebert wrote:
> I can combine these? Not sure.

I think it might be better to turn api_data_source into a factory, so you can
pass in samples as a parameter to Create. This might not be thread safe.

[chebert, 2012-07-26 22:30:51]

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/api_data_source.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/api_data_source.py:19: def __init__(self,
cache_builder, base_path):
On 2012/07/26 22:04:24, cduvall wrote:
> See comment in TDS about factory so this can take samples in its constructor.

Done.

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/handlebar_dict_generator.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/handlebar_dict_generator.py:73: if
api_name == api['name'].split('.', 2)[1]:
On 2012/07/26 22:04:24, cduvall wrote:
> On 2012/07/26 20:36:39, chebert wrote:
> > not sure if this is "safe"
> 
> I would just do:
> if api_name in api['name']:

Done.

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/template_data_source.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/template_data_source.py:92:
self._api_data_source.samples = self._samples_data_source.get(samples_key)
On 2012/07/26 22:04:24, cduvall wrote:
> On 2012/07/26 20:36:39, chebert wrote:
> > I can combine these? Not sure.
> 
> I think it might be better to turn api_data_source into a factory, so you can
> pass in samples as a parameter to Create. This might not be thread safe.

Done.

[cduvall, 2012-07-26 22:38:24]

Beautiful

https://chromiumcodereview.appspot.com/10835012/diff/10/chrome/common/extensi...
File chrome/common/extensions/docs/server2/handlebar_dict_generator_test.py
(right):

https://chromiumcodereview.appspot.com/10835012/diff/10/chrome/common/extensi...
chrome/common/extensions/docs/server2/handlebar_dict_generator_test.py:28: print
json.dumps(gen.Generate(), indent=2)
remove please :)

https://chromiumcodereview.appspot.com/10835012/diff/10/chrome/common/extensi...
File chrome/common/extensions/docs/server2/templates/private/sample.html
(right):

https://chromiumcodereview.appspot.com/10835012/diff/10/chrome/common/extensi...
chrome/common/extensions/docs/server2/templates/private/sample.html:1: {{name}}
remove please :)

[chebert, 2012-07-26 23:28:36]

https://chromiumcodereview.appspot.com/10835012/diff/10/chrome/common/extensi...
File chrome/common/extensions/docs/server2/handlebar_dict_generator_test.py
(right):

https://chromiumcodereview.appspot.com/10835012/diff/10/chrome/common/extensi...
chrome/common/extensions/docs/server2/handlebar_dict_generator_test.py:28: print
json.dumps(gen.Generate(), indent=2)
On 2012/07/26 22:38:25, cduvall wrote:
> remove please :)

Done.

https://chromiumcodereview.appspot.com/10835012/diff/10/chrome/common/extensi...
File chrome/common/extensions/docs/server2/templates/private/sample.html
(right):

https://chromiumcodereview.appspot.com/10835012/diff/10/chrome/common/extensi...
chrome/common/extensions/docs/server2/templates/private/sample.html:1: {{name}}
On 2012/07/26 22:38:25, cduvall wrote:
> remove please :)

Done.

[not at google - send to devlin, 2012-07-30 12:23:03]

You'll need to update the table of contents too. Regarding that, I was wondering
whether to include the sample names as subheadings; it could make the TOC kind
of unwieldy for large APIs, but we might as well try it for now and see how it
goes.

http://codereview.chromium.org/10835012/diff/2004/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/api_data_source.py (right):

http://codereview.chromium.org/10835012/diff/2004/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/api_data_source.py:31: self._idl_cache =
cache_builder.build(self._LoadIdlAPI)
This means that on every construction (via the Factory) the caches will be
re-created. That kinda defeats the purpose of the caches, and it's one of the
reasons the Factory exists, so that the cache can be shared across all instances
of this.

Have a look at how template_data_source and samples_data_source work. Basically,
the Factory constructs and owns the caches, then passes a reference to the cache
in APIDataSource in its constructor, not its Builder.

That said, the samples are a dependency of HandlebarDictGenerator not this
class, so the injection of the samples should be done there not here.

I.e. the Factory should go on HandlebarDictGenerator
(HandlebarDictGenerator.Factory), and instead of creating a
HandlebarDictGenerator here directly, inject the HDG.Factory and use Create()
rather than the constructor below.

So:
1. add HandlebarDictGenerator.Factory; takes the samples in its constructor.
2. create it in echo_handler.py
3. when classes need to create HandlebarDictGenerators (e.g. this one), inject
it into its constructor.
4. Instead of HandlebarDictGenerator(schema), do
self._handlebar_dict_generator_factory.Create(schema).

http://codereview.chromium.org/10835012/diff/2004/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/handlebar_dict_generator.py (right):

http://codereview.chromium.org/10835012/diff/2004/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/handlebar_dict_generator.py:76: return
return_samples
Perhaps a list comprehension would be more concise?

http://codereview.chromium.org/10835012/diff/2004/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/templates/private/api_reference.html
(right):

http://codereview.chromium.org/10835012/diff/2004/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/templates/private/api_reference.html:4:
{{/}}
I think this should be the last thing on the page, after the API reference. The
API reference is more likely to be what developers are looking for, not samples.

Also, a couple of ways I think it could be nicer:
- title should be "Samples extensions that use chrome.{{api.name}}"
- don't surround in <code></code>, it's not code.
- have the description after it, so like

<b>Stylizr</b> &ndash; blah blah blah.
<b>Other sample</b> &ndash; foo bar baz.

&ndash; cos it's a longer dash than - but I don't know how it'll look. Use your
judgement (there's also &mdash; along with other types of separators).

[not at google - send to devlin, 2012-07-30 12:26:22]

And by "inject the samples" I mean "inject the samples data source".

http://codereview.chromium.org/10835012/diff/2004/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/template_data_source.py (right):

http://codereview.chromium.org/10835012/diff/2004/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/template_data_source.py:91:
self._samples_data_source.get(''))
This looks kind of strange. Could you add a GetAll() method to
samples_data_source? That would mean that get() just calls into that with "" but
at least it's behind the API not this odd-looking method call.

[chebert, 2012-07-31 22:41:33]

This hasn't changed much...see comments in api_data_source.py

https://chromiumcodereview.appspot.com/10835012/diff/2004/chrome/common/exten...
File chrome/common/extensions/docs/server2/api_data_source.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/2004/chrome/common/exten...
chrome/common/extensions/docs/server2/api_data_source.py:31: self._idl_cache =
cache_builder.build(self._LoadIdlAPI)
The issue I am having with this is that the APIDataSource gets created long
before the samples_data_source is created. 

so basically the earliest place we could make the
handlebar_dict_generator_factory would be in the template_data_source, on its
creation, and immediately after, we would be passing the
handlebar_dict_generator to the api_data_source.

An issue I would then have with the first part, then would be that the
HandlebarDictGenerator is dependent on the samples, so the caches couldn't be
built until this point anyway.

On 2012/07/30 12:23:03, kalman wrote:
> This means that on every construction (via the Factory) the caches will be
> re-created. That kinda defeats the purpose of the caches, and it's one of the
> reasons the Factory exists, so that the cache can be shared across all
instances
> of this.
> 
> Have a look at how template_data_source and samples_data_source work.
Basically,
> the Factory constructs and owns the caches, then passes a reference to the
cache
> in APIDataSource in its constructor, not its Builder.
> 
> That said, the samples are a dependency of HandlebarDictGenerator not this
> class, so the injection of the samples should be done there not here.
> 
> I.e. the Factory should go on HandlebarDictGenerator
> (HandlebarDictGenerator.Factory), and instead of creating a
> HandlebarDictGenerator here directly, inject the HDG.Factory and use Create()
> rather than the constructor below.
> 
> So:
> 1. add HandlebarDictGenerator.Factory; takes the samples in its constructor.
> 2. create it in echo_handler.py
> 3. when classes need to create HandlebarDictGenerators (e.g. this one), inject
> it into its constructor.
> 4. Instead of HandlebarDictGenerator(schema), do
> self._handlebar_dict_generator_factory.Create(schema).

https://chromiumcodereview.appspot.com/10835012/diff/2004/chrome/common/exten...
File chrome/common/extensions/docs/server2/handlebar_dict_generator.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/2004/chrome/common/exten...
chrome/common/extensions/docs/server2/handlebar_dict_generator.py:76: return
return_samples
On 2012/07/30 12:23:03, kalman wrote:
> Perhaps a list comprehension would be more concise?

Done.

https://chromiumcodereview.appspot.com/10835012/diff/2004/chrome/common/exten...
File chrome/common/extensions/docs/server2/template_data_source.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/2004/chrome/common/exten...
chrome/common/extensions/docs/server2/template_data_source.py:91:
self._samples_data_source.get(''))
On 2012/07/30 12:26:22, kalman wrote:
> This looks kind of strange. Could you add a GetAll() method to
> samples_data_source? That would mean that get() just calls into that with ""
but
> at least it's behind the API not this odd-looking method call.

Done.

https://chromiumcodereview.appspot.com/10835012/diff/2004/chrome/common/exten...
File chrome/common/extensions/docs/server2/templates/private/api_reference.html
(right):

https://chromiumcodereview.appspot.com/10835012/diff/2004/chrome/common/exten...
chrome/common/extensions/docs/server2/templates/private/api_reference.html:4:
{{/}}
On 2012/07/30 12:23:03, kalman wrote:
> I think this should be the last thing on the page, after the API reference.
The
> API reference is more likely to be what developers are looking for, not
samples.
> 
> Also, a couple of ways I think it could be nicer:
> - title should be "Samples extensions that use chrome.{{api.name}}"
> - don't surround in <code></code>, it's not code.
> - have the description after it, so like
> 
> <b>Stylizr</b> &ndash; blah blah blah.
> <b>Other sample</b> &ndash; foo bar baz.
> 
> &ndash; cos it's a longer dash than - but I don't know how it'll look. Use
your
> judgement (there's also &mdash; along with other types of separators).

Done.

[not at google - send to devlin, 2012-08-01 10:09:18]

TOC still needs to be updated.

https://chromiumcodereview.appspot.com/10835012/diff/2004/chrome/common/exten...
File chrome/common/extensions/docs/server2/api_data_source.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/2004/chrome/common/exten...
chrome/common/extensions/docs/server2/api_data_source.py:31: self._idl_cache =
cache_builder.build(self._LoadIdlAPI)
On 2012/07/31 22:41:33, chebert wrote:
> The issue I am having with this is that the APIDataSource gets created long
> before the samples_data_source is created. 
> 
> so basically the earliest place we could make the
> handlebar_dict_generator_factory would be in the template_data_source, on its
> creation, and immediately after, we would be passing the
> handlebar_dict_generator to the api_data_source.
> 
> An issue I would then have with the first part, then would be that the
> HandlebarDictGenerator is dependent on the samples, so the caches couldn't be
> built until this point anyway.
> 
> On 2012/07/30 12:23:03, kalman wrote:
> > This means that on every construction (via the Factory) the caches will be
> > re-created. That kinda defeats the purpose of the caches, and it's one of
the
> > reasons the Factory exists, so that the cache can be shared across all
> instances
> > of this.
> > 
> > Have a look at how template_data_source and samples_data_source work.
> Basically,
> > the Factory constructs and owns the caches, then passes a reference to the
> cache
> > in APIDataSource in its constructor, not its Builder.
> > 
> > That said, the samples are a dependency of HandlebarDictGenerator not this
> > class, so the injection of the samples should be done there not here.
> > 
> > I.e. the Factory should go on HandlebarDictGenerator
> > (HandlebarDictGenerator.Factory), and instead of creating a
> > HandlebarDictGenerator here directly, inject the HDG.Factory and use
Create()
> > rather than the constructor below.
> > 
> > So:
> > 1. add HandlebarDictGenerator.Factory; takes the samples in its constructor.
> > 2. create it in echo_handler.py
> > 3. when classes need to create HandlebarDictGenerators (e.g. this one),
inject
> > it into its constructor.
> > 4. Instead of HandlebarDictGenerator(schema), do
> > self._handlebar_dict_generator_factory.Create(schema).
> 

Ah sorry, looks like I confused myself, and you in the process. My apologies.

Yeah, HandlebarDictGenerator has a semantically different lifetime to the
DataSources:

The DataSource classes are scoped to requests, meaning that each will probably
need a Factory with a Create(request) method on it (for those that don't, it's
somewhat inevitable). Perhaps we should just go through and do that for all of
them to make it clearer.

HandlebarDictGenerator on the other hand is basically, itself, a factory-style
object for dicts to pass through to the Handlebar objects.
HandlebarDictGenerator is the Factory, .Generate() is like Create(), except
instead of returning classes it returns dicts.

However, I think this stuff will be easier to follow if we treat
HandlebarDictGenerator as just exposing data to Handlebar templates; so pass the
relevant data (e.g. the samples) into Generate.

I've written what I meant here: https://chromiumcodereview.appspot.com/10830115/

sorry about all this building-up-injection stuff, but once it's done, it's done.

https://chromiumcodereview.appspot.com/10835012/diff/11001/chrome/common/exte...
File chrome/common/extensions/docs/server2/handlebar_dict_generator.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/11001/chrome/common/exte...
chrome/common/extensions/docs/server2/handlebar_dict_generator.py:36:
self._samples = samples
see example I mentioned

https://chromiumcodereview.appspot.com/10835012/diff/11001/chrome/common/exte...
File chrome/common/extensions/docs/server2/samples_data_source.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/11001/chrome/common/exte...
chrome/common/extensions/docs/server2/samples_data_source.py:125: return
self.get('')
call GetAll plz.

Incidentally we should rename all these get() to Get(), for python-style-guide
reasons.

https://chromiumcodereview.appspot.com/10835012/diff/11001/chrome/common/exte...
File chrome/common/extensions/docs/server2/template_data_source.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/11001/chrome/common/exte...
chrome/common/extensions/docs/server2/template_data_source.py:91:
self._samples_data_source.values())
usually you'd pass through the instance itself, not its factory (same as the
line above). I've done this in the example.

[chebert, 2012-08-01 18:04:33]

https://chromiumcodereview.appspot.com/10835012/diff/11001/chrome/common/exte...
File chrome/common/extensions/docs/server2/handlebar_dict_generator.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/11001/chrome/common/exte...
chrome/common/extensions/docs/server2/handlebar_dict_generator.py:36:
self._samples = samples
On 2012/08/01 10:09:19, kalman wrote:
> see example I mentioned

Done.

https://chromiumcodereview.appspot.com/10835012/diff/11001/chrome/common/exte...
File chrome/common/extensions/docs/server2/samples_data_source.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/11001/chrome/common/exte...
chrome/common/extensions/docs/server2/samples_data_source.py:125: return
self.get('')
The reason they are called get() and values() is to match the python dictionary
language.

In the tests these classes are treated like empty dictionaries, so the other
option is to change the tests.

On 2012/08/01 10:09:19, kalman wrote:
> call GetAll plz.
> 
> Incidentally we should rename all these get() to Get(), for python-style-guide
> reasons.

[chebert, 2012-08-01 18:04:51]

https://chromiumcodereview.appspot.com/10835012/diff/11001/chrome/common/exte...
File chrome/common/extensions/docs/server2/template_data_source.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/11001/chrome/common/exte...
chrome/common/extensions/docs/server2/template_data_source.py:91:
self._samples_data_source.values())
On 2012/08/01 10:09:19, kalman wrote:
> usually you'd pass through the instance itself, not its factory (same as the
> line above). I've done this in the example.

Done.

[not at google - send to devlin, 2012-08-01 20:56:32]

Nice one, lgtm.

Please fix up those things before submitting. The injection stuff in
template_data_source.py is a bug.

http://codereview.chromium.org/10835012/diff/11001/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/samples_data_source.py (right):

http://codereview.chromium.org/10835012/diff/11001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/samples_data_source.py:125: return
self.get('')
On 2012/08/01 18:04:33, chebert wrote:
> The reason they are called get() and values() is to match the python
dictionary
> language.
> 
> In the tests these classes are treated like empty dictionaries, so the other
> option is to change the tests.
> 
> On 2012/08/01 10:09:19, kalman wrote:
> > call GetAll plz.
> > 
> > Incidentally we should rename all these get() to Get(), for
python-style-guide
> > reasons.
> 

Ah cool. No problem.

http://codereview.chromium.org/10835012/diff/5008/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/api_data_source.py (right):

http://codereview.chromium.org/10835012/diff/5008/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/api_data_source.py:90: except Exception as
e:
Like I did in that other patch, could you change these to OSError not Exception?
I found that it was catching problems with my code, which shoudn't happen (it
should only catch problems with reading the file).

http://codereview.chromium.org/10835012/diff/5008/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/handlebar_dict_generator.py (right):

http://codereview.chromium.org/10835012/diff/5008/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/handlebar_dict_generator.py:145: def
_FilterSamples(self, samples):
Perhaps pass the filtered results directly into Generate? That way you don't
need to duplicate this code here and in samples_data_source.py.

http://codereview.chromium.org/10835012/diff/5008/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/template_data_source.py (right):

http://codereview.chromium.org/10835012/diff/5008/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/template_data_source.py:91:
self._samples_data_source)
Something funky happened here, Create takes a request object not a samples data
source.

If you moved the Create calls out of __init__ and into Create this would become
clearer, I think. I.e. only pass concrete classes into here, no factories.

[chebert, 2012-08-02 18:40:23]

https://chromiumcodereview.appspot.com/10835012/diff/5008/chrome/common/exten...
File chrome/common/extensions/docs/server2/api_data_source.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/5008/chrome/common/exten...
chrome/common/extensions/docs/server2/api_data_source.py:90: except Exception as
e:
On 2012/08/01 20:56:32, kalman wrote:
> Like I did in that other patch, could you change these to OSError not
Exception?
> I found that it was catching problems with my code, which shoudn't happen (it
> should only catch problems with reading the file).

Done.

https://chromiumcodereview.appspot.com/10835012/diff/5008/chrome/common/exten...
File chrome/common/extensions/docs/server2/handlebar_dict_generator.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/5008/chrome/common/exten...
chrome/common/extensions/docs/server2/handlebar_dict_generator.py:145: def
_FilterSamples(self, samples):
On 2012/08/01 20:56:32, kalman wrote:
> Perhaps pass the filtered results directly into Generate? That way you don't
> need to duplicate this code here and in samples_data_source.py.

Done.

https://chromiumcodereview.appspot.com/10835012/diff/5008/chrome/common/exten...
File chrome/common/extensions/docs/server2/template_data_source.py (right):

https://chromiumcodereview.appspot.com/10835012/diff/5008/chrome/common/exten...
chrome/common/extensions/docs/server2/template_data_source.py:91:
self._samples_data_source)
On 2012/08/01 20:56:32, kalman wrote:
> Something funky happened here, Create takes a request object not a samples
data
> source.
> 
> If you moved the Create calls out of __init__ and into Create this would
become
> clearer, I think. I.e. only pass concrete classes into here, no factories.

Done.

[commit-bot: I haz the power, 2012-08-02 18:53:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hebert.christopherj@chromium.org/10835...

[commit-bot: I haz the power, 2012-08-02 20:22:41]

Change committed as 149690