chrome/common/extensions/docs/server2/templates/private/api_reference.html - Issue 10835012: Extension Docs Server: Include a list of samples used in the api reference page.

Side by Side Diff: chrome/common/extensions/docs/server2/templates/private/api_reference.html

Issue 10835012: Extension Docs Server: Include a list of samples used in the api reference page. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: fixed the tests Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/server2/template_data_source.py ('K') | « chrome/common/extensions/docs/server2/template_data_source_test.py ('k') | chrome/common/extensions/docs/server2/test_data/test_json/expected_test_file.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	1 {{?api.samples}}<h2>Samples Using chrome.{{api.name}}</h2>{{/}}

	2 {{#api.samples}}

	3 <li><code><a href="{{path}}.zip">{{name}}</a></code></li>

	4 {{/}}
	not at google - send to devlin 2012/07/30 12:23:03 I think this should be the last thing on the page, I think this should be the last thing on the page, after the API reference. The API reference is more likely to be what developers are looking for, not samples. Also, a couple of ways I think it could be nicer: - title should be "Samples extensions that use chrome.{{api.name}}" - don't surround in <code></code>, it's not code. - have the description after it, so like <b>Stylizr</b> – blah blah blah. <b>Other sample</b> – foo bar baz. – cos it's a longer dash than - but I don't know how it'll look. Use your judgement (there's also — along with other types of separators). chebert 2012/07/31 22:41:33 Done. Show quoted text On 2012/07/30 12:23:03, kalman wrote: > I think this should be the last thing on the page, after the API reference. The > API reference is more likely to be what developers are looking for, not samples. > > Also, a couple of ways I think it could be nicer: > - title should be "Samples extensions that use chrome.{{api.name}}" > - don't surround in <code></code>, it's not code. > - have the description after it, so like > > <b>Stylizr</b> – blah blah blah. > <b>Other sample</b> – foo bar baz. > > – cos it's a longer dash than - but I don't know how it'll look. Use your > judgement (there's also — along with other types of separators). Done.
1 <a name="apiReference"></a>	5 <a name="apiReference"></a>

2 <h2>API Reference: chrome.{{api.name}}</h2>	6 <h2>API Reference: chrome.{{api.name}}</h2>

3 <div class="api_reference">	7 <div class="api_reference">

4 {{?api.types}}	8 {{?api.types}}

5 <h3 id="types">Types</h3>	9 <h3 id="types">Types</h3>

6 {{#api.types}}	10 {{#api.types}}

7 {{+partials.type api:api type:@}}	11 {{+partials.type api:api type:@}}

8 {{/}}	12 {{/}}

9 {{/api.types}}	13 {{/api.types}}

10 {{?api.properties}}	14 {{?api.properties}}

11 <h3 id="properties">Properties</h3>	15 <h3 id="properties">Properties</h3>

12 {{#api.properties}}	16 {{#api.properties}}

13 {{+partials.api_property api:api}}	17 {{+partials.api_property api:api}}

14 {{/}}	18 {{/}}

15 {{/api.properties}}	19 {{/api.properties}}

16 {{?api.functions}}	20 {{?api.functions}}

17 <h3 id="methods">Methods</h3>	21 <h3 id="methods">Methods</h3>

18 {{#api.functions}}	22 {{#api.functions}}

19 {{+partials.function api:api}}	23 {{+partials.function api:api}}

20 {{/}}	24 {{/}}

21 {{/api.functions}}	25 {{/api.functions}}

22 {{?api.events}}	26 {{?api.events}}

23 <h3 id="events">Events</h3>	27 <h3 id="events">Events</h3>

24 {{#api.events}}	28 {{#api.events}}

25 {{+partials.event api:api}}	29 {{+partials.event api:api}}

26 {{/}}	30 {{/}}

27 {{/api.events}}	31 {{/api.events}}

28 </div>	32 </div>

OLD	NEW