Chrome OS "open with" picker allowing Web Intents

chrome/browser/chromeos/extensions/file_handler_util.h

Index: chrome/browser/chromeos/extensions/file_handler_util.h
diff --git a/chrome/browser/chromeos/extensions/file_handler_util.h b/chrome/browser/chromeos/extensions/file_handler_util.h
index 6fb8d25fc8106fc8a97b440cd532a8618b8e7c01..5bb739ddb7b22169bda2cb76f4aeee052af93f41 100644
--- a/chrome/browser/chromeos/extensions/file_handler_util.h
+++ b/chrome/browser/chromeos/extensions/file_handler_util.h
@@ -26,7 +26,8 @@ int GetReadWritePermissions();
 // Gets read-only file access permission flags.
 int GetReadOnlyPermissions();
 
-// Generates file task id for the file action specified by the extension.
+// Generates task id for the file action or Web Intent specified by the
+// extension. This is a Web Intent if |action_id| is prefixed with "http".

[benwells, 2012/08/27 08:02:59]

Using a prefix here feels pretty hacky. Can we pass in an enum saying what type
of task it is?

[thorogood, 2012/08/29 06:34:46]

Yes, I guess so, although I'd probably be keen to add a third parameter then: it
becomes a bit kludgy since we have DriveTasks, WebIntentTasks, and then
"regular" FileActionTasks. This way we have a prefix for all three.

How does that sound?

[thorogood, 2012/08/29 08:58:08]

I've taken on your first suggestion now - like I should have to start with :)

There's now an enum describing the type of task, and that's used in MakeTaskID
and CrackTaskID. There's also some relevant JS changes in the file browser code
since the TaskID now has three fields instead of just two.

 std::string MakeTaskID(const std::string& extension_id,
                        const std::string& action_id);