Chrome OS "open with" picker allowing Web Intents

chrome/browser/chromeos/extensions/file_handler_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_HANDLER_UTIL_H_
 #define CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_HANDLER_UTIL_H_
 
 #include <vector>
 
 #include "base/callback.h"
 #include "base/platform_file.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/url_pattern_set.h"
 
 class Browser;
 class FileBrowserHandler;
 class GURL;
 class Profile;
 
 namespace file_handler_util {
 
 void UpdateFileHandlerUsageStats(Profile* profile, const std::string& task_id);
 
 // Gets read-write file access permission flags.
 int GetReadWritePermissions();
 // Gets read-only file access permission flags.
 int GetReadOnlyPermissions();
 
-// Generates file task id for the file action specified by the extension.
+// Generates task id for the file action or Web Intent specified by the
+// extension. This is a Web Intent if |action_id| is prefixed with "http".

[benwells, 2012/08/27 08:02:59]

Using a prefix here feels pretty hacky. Can we pass in an enum saying what type
of task it is?

[thorogood, 2012/08/29 06:34:46]

Yes, I guess so, although I'd probably be keen to add a third parameter then: it
becomes a bit kludgy since we have DriveTasks, WebIntentTasks, and then
"regular" FileActionTasks. This way we have a prefix for all three.

How does that sound?

[thorogood, 2012/08/29 08:58:08]

I've taken on your first suggestion now - like I should have to start with :)

There's now an enum describing the type of task, and that's used in MakeTaskID
and CrackTaskID. There's also some relevant JS changes in the file browser code
since the TaskID now has three fields instead of just two.

 std::string MakeTaskID(const std::string& extension_id,
                        const std::string& action_id);
 
 // Make a task id specific to drive apps instead of extensions.
 std::string MakeDriveTaskID(const std::string& app_id,
                             const std::string& action_id);
 
 // Extracts action and extension id bound to the file task.
 bool CrackTaskID(const std::string& task_id,
                  std::string* target_extension_id,
@@ skipping 65 matching lines @@
   Browser* GetBrowser() const;
  private:
   friend class base::RefCountedThreadSafe<FileTaskExecutor>;
 
   Profile* profile_;
 };
 
 }  // namespace file_handler_util
 
 #endif  // CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_HANDLER_UTIL_H_