Issue 10834382: mac: Remove implicit conversion from ImageSkia to SkBitmap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834382: mac: Remove implicit conversion from ImageSkia to SkBitmap. (Closed)

Created:
8 years, 4 months ago by sadrul

Modified:
8 years, 4 months ago

Reviewers:
Nico

CC:
chromium-reviews, Aaron Boodman, rsesek+watch_chromium.org, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

mac: Remove implicit conversion from ImageSkia to SkBitmap. BUG=141146, 132327 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152592

Patch Set 3 : tot-merge #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -6 lines)			Patch
M	chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	skia/ext/skia_utils_mac.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	skia/ext/skia_utils_mac.mm	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	ui/gfx/image/image_skia.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/image/image_skia_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/image/image_skia_util_mac.h	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	ui/gfx/image/image_skia_util_mac.mm	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm http://codereview.chromium.org/10834382/diff/1/ui/gfx/image/image_skia_util_mac.mm File ui/gfx/image/image_skia_util_mac.mm (right): http://codereview.chromium.org/10834382/diff/1/ui/gfx/image/image_skia_util_mac.mm#newcode112 ui/gfx/image/image_skia_util_mac.mm:112: std::vector<gfx::ImageSkiaRep> image_reps = image_skia.GetRepresentations(); const ref?

8 years, 4 months ago (2012-08-17 05:32:35 UTC) #2

sadrul

8 years, 4 months ago (2012-08-17 05:57:43 UTC) #3

Thanks!

http://codereview.chromium.org/10834382/diff/1/ui/gfx/image/image_skia_util_m...
File ui/gfx/image/image_skia_util_mac.mm (right):

http://codereview.chromium.org/10834382/diff/1/ui/gfx/image/image_skia_util_m...
ui/gfx/image/image_skia_util_mac.mm:112: std::vector<gfx::ImageSkiaRep>
image_reps = image_skia.GetRepresentations();
On 2012/08/17 05:32:35, Nico wrote:
> const ref?

Done.

Expand Messages | Collapse Messages

Issue 10834382: mac: Remove implicit conversion from ImageSkia to SkBitmap. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : tot-merge #

Messages