Issue 10834251: Revert 148201 - Re-enable OTP sign in on trunk by reverting most of 147297.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834251: Revert 148201 - Re-enable OTP sign in on trunk by reverting most of 147297. (Closed)

Created:
8 years, 4 months ago by Roger Tawa OOO till Jul 10th

Modified:
8 years, 4 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 148201 - Re-enable OTP sign in on trunk by reverting most of 147297. I am not simply reverting 147297 because that CL included some js code for correctly handling errors in the ASP case, and that is still useful should the user decide to go back to ASPs. Change that disabled OTP on trunk: https://chromiumcodereview.appspot.com/10800010 http:crrev.com/147297 BUG=137772, 141636 TEST=Signing in should ask for OTP instead of ASP. Review URL: https://chromiumcodereview.appspot.com/10800010 Review URL: https://chromiumcodereview.appspot.com/10818006 TBR=rogerta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150797

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -22 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_harness.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
MM	chrome/browser/ui/webui/sync_setup_handler_unittest.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
MM	chrome/common/chrome_switches.h	View	2 chunks	+1 line, -1 line	0 comments	Download
MM	chrome/common/chrome_switches.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 1 (0 generated)