Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 10800010: Revert 140439 - Make OTP sign in on by default. It can be turned off in about:flags (Closed)

Created:
8 years, 5 months ago by Roger Tawa OOO till Jul 10th
Modified:
8 years, 5 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

This CL reverts: 140439 - Make OTP sign in on by default. It can be turned off in about:flags BUG=81265 TEST=Signing in should ask for OTP instead of ASP. for the M21 branch. This is being committed to trunk first so we can test it in canary for a little while before merging to M21. Once merged, this will be reverted so that OTP sign in becomes the default again in M22. This CL includes some string changes in the about:flags page which normally would not be allowed for merging into M21, but because this reverts back to string used in M20 this should be fine. Drover did not work for reverting because there have been other changes since 140439 causing build breaks, so doing the revert manually. OTP sign is still available in the binary, but needs to be manually enabled in about:flags. BUG=81265 TEST=Signing in should ask for ASP instead of OTP. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147297

Patch Set 1 #

Patch Set 2 : Manual changes #

Patch Set 3 : Fix error handling for ASPs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -29 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/sync_setup_overlay.js View 1 2 4 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_harness.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Roger Tawa OOO till Jul 10th
8 years, 5 months ago (2012-07-18 14:28:53 UTC) #1
Roger Tawa OOO till Jul 10th
Hi Tim, James, Please take a look. James: please look at the js file. Thanks.
8 years, 5 months ago (2012-07-18 16:20:27 UTC) #2
James Hawkins
LGTM
8 years, 5 months ago (2012-07-18 16:22:21 UTC) #3
tim (not reviewing)
:( LGTM
8 years, 5 months ago (2012-07-18 18:06:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/10800010/5003
8 years, 5 months ago (2012-07-18 18:20:07 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-18 19:49:30 UTC) #6
Change committed as 147297

Powered by Google App Engine
This is Rietveld 408576698