Issue 10834241: Change Font Settings Sample Extension to use an options page instead of browser action.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834241: Change Font Settings Sample Extension to use an options page instead of browser action. (Closed)

Created:
8 years, 4 months ago by falken

Modified:
8 years, 4 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change Font Settings Sample Extension to use an options page instead of browser action. As suggested by UI leads. The goal is to put the sample extension in the Web Store, but it must be polished up a little first. BUG=114805 TBR=mpcomplete Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150759

Patch Set 1 #

Patch Set 2 : patch for landing #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -377 lines)			Patch
M	chrome/common/extensions/docs/examples/api/fontSettings.zip	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/fontSettings/manifest.json	View		1 chunk	+1 line, -4 lines	0 comments	Download
A +	chrome/common/extensions/docs/examples/api/fontSettings/options.html	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/common/extensions/docs/examples/api/fontSettings/options.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/common/extensions/docs/examples/api/fontSettings/popup.html	View		1 chunk	+0 lines, -114 lines	0 comments	Download
D	chrome/common/extensions/docs/examples/api/fontSettings/popup.js	View		1 chunk	+0 lines, -249 lines	0 comments	Download
M	chrome/common/extensions/docs/extensions/samples.html	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/docs/samples.json	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages