chrome/common/extensions/docs/examples/api/fontSettings/manifest.json - Issue 10834241: Change Font Settings Sample Extension to use an options page instead of browser action.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/examples/api/fontSettings/manifest.json

Issue 10834241: Change Font Settings Sample Extension to use an options page instead of browser action. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch for landing Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/examples/api/fontSettings.zip ('k') | chrome/common/extensions/docs/examples/api/fontSettings/options.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/examples/api/fontSettings/manifest.json

diff --git a/chrome/common/extensions/docs/examples/api/fontSettings/manifest.json b/chrome/common/extensions/docs/examples/api/fontSettings/manifest.json

index cd3e56d8e96a3d739a28324a3071273ddab5a867..9870d5519c8d3c46908680553506a212c9cff59b 100644

--- a/chrome/common/extensions/docs/examples/api/fontSettings/manifest.json

+++ b/chrome/common/extensions/docs/examples/api/fontSettings/manifest.json

@@ -3,10 +3,7 @@

"version": "0.2",

"manifest_version": 2,

"description": "Sample extension for Font Settings API",

- "browser_action" : {

- "default_icon": "fonts16.png",

- "default_popup": "popup.html"

- },

+ "options_page": "options.html",

"icons": {

"16": "fonts16.png",

"128": "fonts128.png"