Issue 10834214: Fix extension docs presubmit. One, not all, of the subdirs should have matching static docs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834214: Fix extension docs presubmit. One, not all, of the subdirs should have matching static docs. (Closed)

Created:
8 years, 4 months ago by Yoyo Zhou

Modified:
8 years, 4 months ago

Reviewers:
Aaron Boodman, Joao da Silva

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix extension docs presubmit. One, not all, of the subdirs should have matching static docs. BUG=111465 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150431

Patch Set 1 #

Patch Set 2 : test #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -5 lines)			Patch
	M	chrome/common/extensions/PRESUBMIT.py	View		1 chunk	+3 lines, -3 lines	1 comment	Download
	M	chrome/common/extensions/PRESUBMIT_test.py	View	1	1 chunk	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

P.S. I realize that the given, test case "index.html" probably should appear in both apps/ ...

8 years, 4 months ago (2012-08-07 21:29:52 UTC) #2

Aaron Boodman

It's really more like 50/50. But I think since build.py is the only way to ...

8 years, 4 months ago (2012-08-07 22:11:23 UTC) #3

Joao da Silva

8 years, 4 months ago (2012-08-08 09:11:50 UTC) #4

lgtm!

http://codereview.chromium.org/10834214/diff/2001/chrome/common/extensions/PR...
File chrome/common/extensions/PRESUBMIT.py (right):

http://codereview.chromium.org/10834214/diff/2001/chrome/common/extensions/PR...
chrome/common/extensions/PRESUBMIT.py:152: return False
I'll be wearing a brown bag over my head today ._.

Expand Messages | Collapse Messages