Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1886)

Unified Diff: chrome/common/extensions/PRESUBMIT_test.py

Issue 10834214: Fix extension docs presubmit. One, not all, of the subdirs should have matching static docs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: test Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/PRESUBMIT_test.py
diff --git a/chrome/common/extensions/PRESUBMIT_test.py b/chrome/common/extensions/PRESUBMIT_test.py
index ac7a182d8e28ce500f61143e0c95f1abe008aa6c..d20ab93081631ec287598f6f70d7103d3f96a363 100755
--- a/chrome/common/extensions/PRESUBMIT_test.py
+++ b/chrome/common/extensions/PRESUBMIT_test.py
@@ -259,18 +259,27 @@ class TestPresubmit(unittest.TestCase):
FakeAffectedFile(local_path='chrome/common/extensions/docs/two.html')])
self.assertFalse(PRESUBMIT.NonGeneratedFilesEdited(input_api))
- def testStaticDocBuilt_ChangesMatch(self):
+ def testStaticDocBuilt_ChangesMatchApps(self):
static_file = FakeAffectedFile(
local_path='chrome/common/extensions/docs/static/index.html',
changed_contents=[(3, 'foo!'), (4, 'bar!')])
generated_apps_file = FakeAffectedFile(
local_path='chrome/common/extensions/docs/apps/index.html',
changed_contents=[(13, 'foo!'), (14, 'bar!')])
+ input_api = FakeInputApi(affected_files=[
+ generated_apps_file,
+ static_file])
+
+ self.assertTrue(PRESUBMIT.StaticDocBuilt(static_file, input_api))
+
+ def testStaticDocBuilt_ChangesMatchExtensions(self):
+ static_file = FakeAffectedFile(
+ local_path='chrome/common/extensions/docs/static/index.html',
+ changed_contents=[(3, 'foo!'), (4, 'bar!')])
generated_extensions_file = FakeAffectedFile(
local_path='chrome/common/extensions/docs/extensions/index.html',
changed_contents=[(13, 'foo!'), (14, 'bar!')])
input_api = FakeInputApi(affected_files=[
- generated_apps_file,
generated_extensions_file,
static_file])
« chrome/common/extensions/PRESUBMIT.py ('K') | « chrome/common/extensions/PRESUBMIT.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698