Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 10834199: Enable memory profiler on Linux when TC_MALLOC is enabled. (Closed)

Created:
8 years, 4 months ago by ramant (doing other things)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, erikwright (departed), jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Enable memory profiler on Linux when TC_MALLOC is enabled. Added a tc_malloc memory extension to get bytes allocated on current thread (GetBytesAllocatedOnCurrentThread API call). R=jam@chromium.org,jar@chromium.org BUG=139667 TEST=test about:profiler after setting the env variable CHROME_PROFILER_TIME=1. In about:profiler, it will show the memory allocated per thread. This change impacts linux only. This is same as the following previously approved CL. Added needed BASE_EXPORT for kAlternateProfilerTime and SetAlternateTimeSource. the https://chromiumcodereview.appspot.com/10820063/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150477

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M base/profiler/alternate_timer.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/app/content_main_runner.cc View 1 3 chunks +14 lines, -0 lines 0 comments Download
M third_party/tcmalloc/chromium/src/gperftools/malloc_extension.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M third_party/tcmalloc/chromium/src/malloc_extension.cc View 1 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
ramant (doing other things)
Hi John Abd-El-Malek, jar, This is same change as the CL you had approved. Added ...
8 years, 4 months ago (2012-08-07 18:02:52 UTC) #1
jam
lgtm
8 years, 4 months ago (2012-08-07 20:35:51 UTC) #2
jar (doing other things)
lgtm
8 years, 4 months ago (2012-08-07 22:07:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10834199/1
8 years, 4 months ago (2012-08-07 23:11:57 UTC) #4
commit-bot: I haz the power
Try job failure for 10834199-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-07 23:30:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10834199/5004
8 years, 4 months ago (2012-08-07 23:54:14 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 01:27:05 UTC) #7
Change committed as 150477

Powered by Google App Engine
This is Rietveld 408576698