Issue 10855010: Reverting this to see if it fixes the redness on the ChromiumOS bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10855010: Reverting this to see if it fixes the redness on the ChromiumOS bots. (Closed)

Created:
8 years, 4 months ago by ananta

Modified:
8 years, 4 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, pam+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Reverting this to see if it fixes the redness on the ChromiumOS bots. Revert 150135 - Enable memory profiler on Linux when TC_MALLOC is enabled. Added a tc_malloc memory extension to get bytes allocated on current thread (GetBytesAllocatedOnCurrentThread API call). R=jam@chromium.org,jar@chromium.org BUG=139667 TEST=test about:profiler after setting the env variable CHROME_PROFILER_TIME=1. In about:profiler, it will show the memory allocated per thread. This change impacts linux only. Review URL: https://chromiumcodereview.appspot.com/10820063 TBR=rtenneti@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150142

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -25 lines)			Patch
M	content/app/content_main_runner.cc	View	3 chunks	+0 lines, -14 lines	0 comments	Download
M	third_party/tcmalloc/chromium/src/gperftools/malloc_extension.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	third_party/tcmalloc/chromium/src/malloc_extension.cc	View	3 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages