Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10834082: Pass through Extension::FROM_WEBSTORE to Extension::Create when installing an (Closed)

Created:
8 years, 4 months ago by not at google - send to devlin
Modified:
8 years, 4 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, benwells, koz (OOO until 15th September), aboxhall
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Pass through Extension::FROM_WEBSTORE to Extension::Create when installing an extension from the webstore. Without that, webstore-specific permissions checking doesn't happen, notably, whitelisted extensions requesting the "experimental" permission (e.g. Accessibility Developer Tools) can't be installed without enabling experimental APIs in about:flags. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149190

Patch Set 1 #

Patch Set 2 : remove IWYU import fix, could cause cherry-pick problems if we do that #

Total comments: 2

Patch Set 3 : add REQUIRE_KEY #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
not at google - send to devlin
8 years, 4 months ago (2012-07-31 09:38:36 UTC) #1
Aaron Boodman
https://chromiumcodereview.appspot.com/10834082/diff/2001/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc (right): https://chromiumcodereview.appspot.com/10834082/diff/2001/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc#newcode362 chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:362: Extension::FROM_WEBSTORE, I am not sure this is the only ...
8 years, 4 months ago (2012-07-31 09:55:58 UTC) #2
not at google - send to devlin
https://chromiumcodereview.appspot.com/10834082/diff/2001/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc (right): https://chromiumcodereview.appspot.com/10834082/diff/2001/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc#newcode362 chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:362: Extension::FROM_WEBSTORE, On 2012/07/31 09:55:59, Aaron Boodman wrote: > I ...
8 years, 4 months ago (2012-07-31 12:11:31 UTC) #3
Aaron Boodman
LGTM
8 years, 4 months ago (2012-07-31 14:01:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10834082/5001
8 years, 4 months ago (2012-07-31 14:02:05 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 15:46:18 UTC) #6 
Change committed as 149190

Powered by Google App Engine
This is Rietveld 408576698