Pass through Extension::FROM_WEBSTORE to Extension::Create when installing an

chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/webstore_private/webstore_private_api.h"
 
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_vector.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
@@ skipping 340 matching lines @@
     const std::string& id,
     const SkBitmap& icon,
     DictionaryValue* parsed_manifest) {
   CHECK_EQ(id_, id);
   CHECK(parsed_manifest);
   icon_ = icon;
   parsed_manifest_.reset(parsed_manifest);
 
   std::string error;
   dummy_extension_ = ExtensionInstallPrompt::GetLocalizedExtensionForDisplay(
-      parsed_manifest_.get(), id, localized_name_, "", &error);
+      parsed_manifest_.get(),
+      Extension::FROM_WEBSTORE,

[Aaron Boodman, 2012/07/31 09:55:59]

I am not sure this is the only flag that should be passed. Can you look around
and see where other Extension objects get created in this context and see if
other flags are passed that might need to be passed here?`

[not at google - send to devlin, 2012/07/31 12:11:32]

It looks like the interesting code is in InstalledLoader::GetCreationFlags
(installed_loader.cc), and of those, it would set the "REQUIRE_KEY" flag. So
I've added that.

+      id,
+      localized_name_,
+      "",
+      &error);
 
   if (!dummy_extension_) {
     OnWebstoreParseFailure(id_, WebstoreInstallHelper::Delegate::MANIFEST_ERROR,
                            kInvalidManifestError);
     return;
   }
 
   install_prompt_.reset(
       chrome::CreateExtensionInstallPromptWithBrowser(GetCurrentBrowser()));
   install_prompt_->ConfirmWebstoreInstall(this, dummy_extension_, &icon_);
@@ skipping 222 matching lines @@
   feature_checker_->CheckGPUFeatureAvailability();
   return true;
 }
 
 void GetWebGLStatusFunction::OnFeatureCheck(bool feature_allowed) {
   CreateResult(feature_allowed);
   SendResponse(true);
 }
 
 }  // namespace extensions