Issue 10834079: views: Extract Widget observer into its own header file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834079: views: Extract Widget observer into its own header file. (Closed)

Created:
8 years, 4 months ago by tfarina

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, jennb, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, tfarina, Dmitry Titov, dcheng, msw+watch_chromium.org, jianli, oshima+watch_chromium.org, alicet1, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Extract Widget observer into its own header file. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149555

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+139 lines, -94 lines)			Patch
M	ash/launcher/overflow_bubble.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ash/launcher/overflow_bubble.cc	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/system/tray/system_tray_bubble.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ash/system/tray/system_tray_bubble.cc	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/system/tray/tray_bubble_view.cc	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/system/web_notification/web_notification_tray.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	ash/touch/touch_observer_hud.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ash/wm/app_list_controller.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ash/wm/app_list_controller.cc	View	1 2 3 4	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/captive_portal_window_proxy.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/captive_portal_window_proxy.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/data_promo_notification.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/status/data_promo_notification.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_view.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_view.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/accessibility/invert_bubble_view.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/browser_actions_container.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/browser_actions_container.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/confirm_bubble_views.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_popup.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/first_run_bubble.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/app_non_client_frame_view_aura.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/content_setting_image_view.h	View		3 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/content_setting_image_view.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/page_action_image_view.h	View	1 2 3 4	4 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/zoom_bubble_view.cc	View	1 2 3 4 5	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_views.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_drag_controller.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/toolbar_view.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/bubble/bubble_delegate.h	View		3 chunks	+5 lines, -6 lines	0 comments	Download
M	ui/views/bubble/bubble_delegate.cc	View		5 chunks	+6 lines, -5 lines	0 comments	Download
M	ui/views/view.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/views.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/widget/widget.h	View		7 chunks	+8 lines, -18 lines	0 comments	Download
M	ui/views/widget/widget.cc	View	1 2 3 4	8 chunks	+10 lines, -9 lines	0 comments	Download
A	ui/views/widget/widget_observer.h	View		1 chunk	+31 lines, -0 lines	0 comments	Download
M	ui/views/widget/widget_unittest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages