Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Issue 10834078: Cleanup: Constify more ExtensionService methods, and IWYU. (Closed)

Created:
8 years, 4 months ago by Lei Zhang
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Constify more ExtensionService methods, and IWYU. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152105

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix mac #

Patch Set 4 : #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -50 lines) Patch
M chrome/browser/extensions/api/tabs/tabs.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/convert_web_app_browsertest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 3 4 5 7 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 4 5 10 chunks +28 lines, -23 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/startup_helper.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller_unittest.mm View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc View 1 2 3 4 5 3 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Lei Zhang
8 years, 4 months ago (2012-07-31 02:01:25 UTC) #1
Lei Zhang
+mihai
8 years, 4 months ago (2012-08-08 18:48:40 UTC) #2
Matt Perry
lgtm
8 years, 4 months ago (2012-08-08 19:36:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10834078/4007
8 years, 4 months ago (2012-08-08 19:43:12 UTC) #4
commit-bot: I haz the power
Try job failure for 10834078-4007 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-08 22:35:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10834078/4007
8 years, 4 months ago (2012-08-10 16:42:19 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/views/ash/launcher/chrome_launcher_controller_unittest.cc: While running patch -p0 --forward --force; A chrome/browser/ui/views/ash/launcher patching ...
8 years, 4 months ago (2012-08-10 16:42:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10834078/7007
8 years, 4 months ago (2012-08-17 05:10:52 UTC) #8
commit-bot: I haz the power
Try job failure for 10834078-7007 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-17 05:39:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10834078/43
8 years, 4 months ago (2012-08-17 06:31:24 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 18:07:23 UTC) #11
Change committed as 152105

Powered by Google App Engine
This is Rietveld 408576698