Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: chrome/browser/extensions/api/tabs/tabs.cc

Issue 10834078: Cleanup: Constify more ExtensionService methods, and IWYU. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/tabs/tabs.h" 5 #include "chrome/browser/extensions/api/tabs/tabs.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/base64.h" 11 #include "base/base64.h"
12 #include "base/bind.h" 12 #include "base/bind.h"
13 #include "base/command_line.h"
13 #include "base/logging.h" 14 #include "base/logging.h"
14 #include "base/memory/ref_counted_memory.h" 15 #include "base/memory/ref_counted_memory.h"
15 #include "base/message_loop.h" 16 #include "base/message_loop.h"
16 #include "base/stl_util.h" 17 #include "base/stl_util.h"
17 #include "base/string16.h" 18 #include "base/string16.h"
18 #include "base/string_number_conversions.h" 19 #include "base/string_number_conversions.h"
19 #include "base/string_util.h" 20 #include "base/string_util.h"
20 #include "base/stringprintf.h" 21 #include "base/stringprintf.h"
21 #include "base/utf_string_conversions.h" 22 #include "base/utf_string_conversions.h"
22 #include "chrome/browser/extensions/api/tabs/tabs_constants.h" 23 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 #include "content/public/common/url_constants.h" 70 #include "content/public/common/url_constants.h"
70 #include "skia/ext/image_operations.h" 71 #include "skia/ext/image_operations.h"
71 #include "skia/ext/platform_canvas.h" 72 #include "skia/ext/platform_canvas.h"
72 #include "third_party/skia/include/core/SkBitmap.h" 73 #include "third_party/skia/include/core/SkBitmap.h"
73 #include "ui/base/ui_base_types.h" 74 #include "ui/base/ui_base_types.h"
74 #include "ui/gfx/codec/jpeg_codec.h" 75 #include "ui/gfx/codec/jpeg_codec.h"
75 #include "ui/gfx/codec/png_codec.h" 76 #include "ui/gfx/codec/png_codec.h"
76 77
77 #if defined(USE_ASH) 78 #if defined(USE_ASH)
78 #include "ash/ash_switches.h" 79 #include "ash/ash_switches.h"
79 #include "base/command_line.h"
80 #include "chrome/browser/ui/views/ash/panel_view_aura.h" 80 #include "chrome/browser/ui/views/ash/panel_view_aura.h"
81 #endif 81 #endif
82 82
83 #if defined(OS_WIN) 83 #if defined(OS_WIN)
84 #include "base/win/metro.h" 84 #include "base/win/metro.h"
85 #endif // OS_WIN 85 #endif // OS_WIN
86 86
87 namespace Get = extensions::api::windows::Get; 87 namespace Get = extensions::api::windows::Get;
88 namespace GetAll = extensions::api::windows::GetAll; 88 namespace GetAll = extensions::api::windows::GetAll;
89 namespace GetCurrent = extensions::api::windows::GetCurrent; 89 namespace GetCurrent = extensions::api::windows::GetCurrent;
(...skipping 1730 matching lines...) Expand 10 before | Expand all | Expand 10 after
1820 // called for every API call the extension made. 1820 // called for every API call the extension made.
1821 GotLanguage(language); 1821 GotLanguage(language);
1822 } 1822 }
1823 1823
1824 void DetectTabLanguageFunction::GotLanguage(const std::string& language) { 1824 void DetectTabLanguageFunction::GotLanguage(const std::string& language) {
1825 SetResult(Value::CreateStringValue(language.c_str())); 1825 SetResult(Value::CreateStringValue(language.c_str()));
1826 SendResponse(true); 1826 SendResponse(true);
1827 1827
1828 Release(); // Balanced in Run() 1828 Release(); // Balanced in Run()
1829 } 1829 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698