Coverity: Fully initialize the |trace_| member variable.

Coverity: Fully initialize the |trace_| member variable.

Also changed the type of |count_| to size_t since it's a size variable.

CID_COUNT=1
CID=13504
BUG=none
TEST=none
R=brettw


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148420

[brettw, 2012-07-25 17:37:26]

lgtm

https://chromiumcodereview.appspot.com/10834006/diff/7001/base/debug/stack_tr...
File base/debug/stack_trace_win.cc (right):

https://chromiumcodereview.appspot.com/10834006/diff/7001/base/debug/stack_tr...
base/debug/stack_trace_win.cc:189: for (size_t i = count_; i <
arraysize(trace_); ++i)
I'd probably use kMacTrace here instead (since you already have a nice constant
for this).

[James Hawkins, 2012-07-25 18:58:09]

https://chromiumcodereview.appspot.com/10834006/diff/7001/base/debug/stack_tr...
File base/debug/stack_trace_win.cc (right):

https://chromiumcodereview.appspot.com/10834006/diff/7001/base/debug/stack_tr...
base/debug/stack_trace_win.cc:189: for (size_t i = count_; i <
arraysize(trace_); ++i)
On 2012/07/25 17:37:26, brettw wrote:
> I'd probably use kMacTrace here instead (since you already have a nice
constant
> for this).

OK.  I actually searched for arraysize to get back to this instance and
discovered that the existing code uses arraysize throughout (instead of
kMacTrace).  Should I change all of the usages of arraysize for |trace_|?

[brettw, 2012-07-25 19:25:49]

I guess arraysize is OK if that's what the other code does. I don't think it's a
big deal either way.

[James Hawkins, 2012-07-25 20:15:32]

On 2012/07/25 19:25:49, brettw wrote:
> I guess arraysize is OK if that's what the other code does. I don't think it's
a
> big deal either way.

OK, I'll leave as is to match precedence.  Thanks for the review.

[commit-bot: I haz the power, 2012-07-25 20:16:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jhawkins@chromium.org/10834006/7001

[commit-bot: I haz the power, 2012-07-25 21:43:45]

Change committed as 148420