Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Side by Side Diff: base/debug/stack_trace.cc

Issue 10834006: Coverity: Fully initialize the |trace_| member variable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Build fix. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/debug/stack_trace.h" 5 #include "base/debug/stack_trace.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 8
9 #include <string.h> 9 #include <string.h>
10 10
11 #include <algorithm> 11 #include <algorithm>
12 #include <sstream> 12 #include <sstream>
13 13
14 namespace base { 14 namespace base {
15 namespace debug { 15 namespace debug {
16 16
17 StackTrace::StackTrace(const void* const* trace, size_t count) { 17 StackTrace::StackTrace(const void* const* trace, size_t count) {
18 count = std::min(count, arraysize(trace_)); 18 count = std::min(count, arraysize(trace_));
19 if (count) 19 if (count)
20 memcpy(trace_, trace, count * sizeof(trace_[0])); 20 memcpy(trace_, trace, count * sizeof(trace_[0]));
21 count_ = static_cast<int>(count); 21 count_ = count;
22 } 22 }
23 23
24 StackTrace::~StackTrace() { 24 StackTrace::~StackTrace() {
25 } 25 }
26 26
27 const void *const *StackTrace::Addresses(size_t* count) const { 27 const void *const *StackTrace::Addresses(size_t* count) const {
28 *count = count_; 28 *count = count_;
29 if (count_) 29 if (count_)
30 return trace_; 30 return trace_;
31 return NULL; 31 return NULL;
32 } 32 }
33 33
34 std::string StackTrace::ToString() const { 34 std::string StackTrace::ToString() const {
35 std::stringstream stream; 35 std::stringstream stream;
36 OutputToStream(&stream); 36 OutputToStream(&stream);
37 return stream.str(); 37 return stream.str();
38 } 38 }
39 39
40 } // namespace debug 40 } // namespace debug
41 } // namespace base 41 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698