Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api.cc

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/omnibox/omnibox_api.cc
diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api.cc b/chrome/browser/extensions/api/omnibox/omnibox_api.cc
index de0478870f67a8dcef0c9b0ff2322087ab9fef7b..16d0a09072fa0e69507ca3ffcaf879e6c7e243cd 100644
--- a/chrome/browser/extensions/api/omnibox/omnibox_api.cc
+++ b/chrome/browser/extensions/api/omnibox/omnibox_api.cc
@@ -166,14 +166,14 @@ bool ExtensionOmniboxSuggestion::Populate(const base::DictionaryValue& value,
description_styles.clear();
if (value.HasKey(kSuggestionDescriptionStyles)) {
// This version comes from the extension.
- ListValue* styles = NULL;
+ const ListValue* styles = NULL;
if (!value.GetList(kSuggestionDescriptionStyles, &styles) ||
!ReadStylesFromValue(*styles)) {
return false;
}
} else if (value.HasKey(kSuggestionDescriptionStylesRaw)) {
// This version comes from ToValue(), which we use to persist to disk.
- ListValue* styles = NULL;
+ const ListValue* styles = NULL;
if (!value.GetList(kSuggestionDescriptionStylesRaw, &styles) ||
styles->empty()) {
return false;

Powered by Google App Engine
This is Rietveld 408576698