Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2139)

Unified Diff: chrome/browser/extensions/api/context_menu/context_menu_api.cc

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/context_menu/context_menu_api.cc
diff --git a/chrome/browser/extensions/api/context_menu/context_menu_api.cc b/chrome/browser/extensions/api/context_menu/context_menu_api.cc
index acc80a448deea86d23d7e2236628014c73c7dfa7..15f1af22c903299bc63d92efaa71aeeb58d08711 100644
--- a/chrome/browser/extensions/api/context_menu/context_menu_api.cc
+++ b/chrome/browser/extensions/api/context_menu/context_menu_api.cc
@@ -59,7 +59,7 @@ bool ExtensionContextMenuFunction::ParseContexts(
const DictionaryValue& properties,
const char* key,
MenuItem::ContextList* result) {
- ListValue* list = NULL;
+ const ListValue* list = NULL;
if (!properties.GetList(key, &list)) {
return true;
}
@@ -157,7 +157,7 @@ bool ExtensionContextMenuFunction::GetParent(const DictionaryValue& properties,
if (!properties.HasKey(kParentIdKey))
return true;
MenuItem::Id parent_id(profile()->IsOffTheRecord(), extension_id());
- Value* parent_id_value = NULL;
+ const Value* parent_id_value = NULL;
if (properties.Get(kParentIdKey, &parent_id_value) &&
!ParseID(parent_id_value, &parent_id))
return false;
« no previous file with comments | « chrome/browser/extensions/api/commands/command_service.cc ('k') | chrome/browser/extensions/api/omnibox/omnibox_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698