Issue 10833057: Re-apply CL's to force store-hosted extension update checks to use SSL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10833057: Re-apply CL's to force store-hosted extension update checks to use SSL (Closed)

Created:
8 years, 4 months ago by asargent_no_longer_on_chrome

Modified:
8 years, 4 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Re-apply CL's to force store-hosted extension update checks to use SSL These 2 CL's were reverted due to some DCHECK failures we saw in the field, but it turned out a different change was likely the underlying culprit. I'm now re-applying these changes to solve the original bug. https://chromiumcodereview.appspot.com/10446027 (crrev.com/138961) https://chromiumcodereview.appspot.com/10444063 (crrev.com/139371) TBR=asargent@chromium.org BUG=129587 TEST=Autoupdate and blacklist of extensions/apps from WebStore should still work. Also existing unit/browser tests should pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148843

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -24 lines)			Patch
M	chrome/browser/extensions/updater/extension_downloader.cc	View	5 chunks	+23 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/updater/extension_updater_unittest.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/extensions/webstore_installer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/extension_constants.h	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.cc	View	2 chunks	+9 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/10833057/1

8 years, 4 months ago (2012-07-27 20:25:58 UTC) #1

Change committed as 148843