Fix for sync case in code forcing extension updates to use https

Fix for sync case in code forcing extension updates to use https

The previous CL I landed for this bug did not properly handle the case of sync,
where we "update" from a version of 0 of an extension/app to whatever the
current version is.

BUG=129587
TEST=Starting from a clean profile directory, sign in to sync with an account
that has some extensions and/or apps. You should not get any DHECK failure.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139371

[Mihai Parparita -not on Chrome, 2012-05-29 18:36:32]

LGTM

Out of curiosity, can we do this at an even lower level, like
Extension::InitFromValue (or rather,  Extension::LoadUpdateURL). It seems like
all code paths should end up there.

[asargent_no_longer_on_chrome, 2012-05-29 19:18:04]

On 2012/05/29 18:36:32, Mihai Parparita wrote:
> LGTM
> 
> Out of curiosity, can we do this at an even lower level, like
> Extension::InitFromValue (or rather,  Extension::LoadUpdateURL). It seems like
> all code paths should end up there.

The ExtensionDownloader class has a public "Add PendingExtension" method which
just takes an id and update_url, for cases where we don't have an Extension
object yet.

[commit-bot: I haz the power, 2012-05-29 19:18:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asargent@chromium.org/10444063/1

[commit-bot: I haz the power, 2012-05-29 21:01:35]

Change committed as 139371