Remove blur on bubble windows

Remove blur on bubble windows

Bubble windows sometimes had drawing artifacts. It looks like this was caused by the blur filter we added to those windows.

This CL removes the blur filter (partial revert of r134795 and r147628).

BUG=138761
TEST=Ran and verified that bubble windows looked ok on external display.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148451

[Robert Sesek, 2012-07-25 17:54:23]

Mostly LGTM, though please address the question.

https://chromiumcodereview.appspot.com/10833009/diff/1/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/info_bubble_view.mm (left):

https://chromiumcodereview.appspot.com/10833009/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/info_bubble_view.mm:65: [[NSColor
colorWithCalibratedWhite:1.0 alpha:0.9] set];
What happens if you leave this? The UI people like the effect.

[Nico, 2012-07-25 17:54:44]

lgtm

[sail, 2012-07-25 18:23:14]

https://chromiumcodereview.appspot.com/10833009/diff/1/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/info_bubble_view.mm (left):

https://chromiumcodereview.appspot.com/10833009/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/info_bubble_view.mm:65: [[NSColor
colorWithCalibratedWhite:1.0 alpha:0.9] set];
On 2012/07/25 17:54:23, rsesek wrote:
> What happens if you leave this? The UI people like the effect.

Hi Robert, here's some screenshots with 0.9 alpha:
   http://i.imgur.com/cytSJ.png
   http://i.imgur.com/x92qJ.png
I think it's a little hard to read without the blur filter. Maybe a little less
alpha?

[Robert Sesek, 2012-07-25 18:24:59]

https://chromiumcodereview.appspot.com/10833009/diff/1/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/info_bubble_view.mm (left):

https://chromiumcodereview.appspot.com/10833009/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/info_bubble_view.mm:65: [[NSColor
colorWithCalibratedWhite:1.0 alpha:0.9] set];
On 2012/07/25 18:23:14, sail wrote:
> On 2012/07/25 17:54:23, rsesek wrote:
> > What happens if you leave this? The UI people like the effect.
> 
> Hi Robert, here's some screenshots with 0.9 alpha:
>    http://i.imgur.com/cytSJ.png
>    http://i.imgur.com/x92qJ.png
> I think it's a little hard to read without the blur filter. Maybe a little
less
> alpha?

It's unfortunate that we have to ditch the blur. But, yes, let's try a little
more alpha. I think it looks good overall. I'll leave it to your judgment to
find the right magic number.

Also please test an extension bubble.

[sail, 2012-07-25 18:43:21]

https://chromiumcodereview.appspot.com/10833009/diff/1/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/info_bubble_view.mm (left):

https://chromiumcodereview.appspot.com/10833009/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/info_bubble_view.mm:65: [[NSColor
colorWithCalibratedWhite:1.0 alpha:0.9] set];
On 2012/07/25 18:24:59, rsesek wrote:
> On 2012/07/25 18:23:14, sail wrote:
> > On 2012/07/25 17:54:23, rsesek wrote:
> > > What happens if you leave this? The UI people like the effect.
> > 
> > Hi Robert, here's some screenshots with 0.9 alpha:
> >    http://i.imgur.com/cytSJ.png
> >    http://i.imgur.com/x92qJ.png
> > I think it's a little hard to read without the blur filter. Maybe a little
> less
> > alpha?
> 
> It's unfortunate that we have to ditch the blur. But, yes, let's try a little
> more alpha. I think it looks good overall. I'll leave it to your judgment to
> find the right magic number.
This is at 0.96 which seems more readable to me
    http://i.imgur.com/yIHrm.png
    http://i.imgur.com/ldnOG.png
What do you think?

> Also please test an extension bubble.
Here's a screenshot with adblock
    http://i.imgur.com/A21lr.png
the WebView is completely opaque so doesn't look any different

[Robert Sesek, 2012-07-25 19:41:51]

SHIP IT

LGTM++

[commit-bot: I haz the power, 2012-07-25 19:51:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/10833009/1

[commit-bot: I haz the power, 2012-07-25 20:00:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/10833009/11001

[commit-bot: I haz the power, 2012-07-26 00:49:31]

Change committed as 148451