Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: chrome/browser/ui/cocoa/info_bubble_window.mm

Issue 10833009: Remove blur on bubble windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: change alpha to 0.96 Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/info_bubble_window.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/info_bubble_window.mm
diff --git a/chrome/browser/ui/cocoa/info_bubble_window.mm b/chrome/browser/ui/cocoa/info_bubble_window.mm
index 8b6d767aaa4f5b1f541a6b287525211d5f0272cb..0dbc3a0b23966235538779d8cdc709cd9c45007e 100644
--- a/chrome/browser/ui/cocoa/info_bubble_window.mm
+++ b/chrome/browser/ui/cocoa/info_bubble_window.mm
@@ -6,7 +6,6 @@
#include "base/basictypes.h"
#include "base/logging.h"
-#include "base/mac/foundation_util.h"
#include "base/memory/scoped_nsobject.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -25,25 +24,6 @@ const NSTimeInterval kMinimumTimeInterval =
std::numeric_limits<NSTimeInterval>::min();
} // namespace
-// Forward declare private window server functions used to style the window.
-extern "C" {
-typedef int CGSConnection;
-typedef int CGSWindow;
-typedef void* CGSWindowFilterRef;
-
-CGSConnection _CGSDefaultConnection();
-CGError CGSNewCIFilterByName(CGSConnection cid,
- CFStringRef filterName,
- CGSWindowFilterRef *outFilter);
-CGError CGSAddWindowFilter(CGSConnection cid,
- CGSWindow wid,
- CGSWindowFilterRef filter,
- int flags);
-CGError CGSReleaseCIFilter(CGSConnection cid, CGSWindowFilterRef filter);
-CGError CGSSetCIFilterValuesFromDictionary(
- CGSConnection cid, CGSWindowFilterRef filter, CFDictionaryRef filterValues);
-} // extern "C"
-
@interface InfoBubbleWindow (Private)
- (void)appIsTerminating;
- (void)finishCloseAfterAnimation;
@@ -115,7 +95,6 @@ class AppNotificationBridge : public content::NotificationObserver {
@synthesize delayOnClose = delayOnClose_;
@synthesize canBecomeKeyWindow = canBecomeKeyWindow_;
-@synthesize hasBlurredBackground = hasBlurredBackground_;
- (id)initWithContentRect:(NSRect)contentRect
styleMask:(NSUInteger)aStyle
@@ -131,7 +110,6 @@ class AppNotificationBridge : public content::NotificationObserver {
[self setHasShadow:YES];
delayOnClose_ = YES;
canBecomeKeyWindow_ = YES;
- hasBlurredBackground_ = YES;
notificationBridge_.reset(new AppNotificationBridge(self));
// Start invisible. Will be made visible when ordered front.
@@ -224,25 +202,6 @@ class AppNotificationBridge : public content::NotificationObserver {
newOrigin.y += kOrderInSlideOffset;
[self setFrameOrigin:newOrigin];
- // Add a gaussian blur to the window.
- if (hasBlurredBackground_) {
- CGSConnection cgsConnection = _CGSDefaultConnection();
- CGSWindowFilterRef filter;
- if (CGSNewCIFilterByName(cgsConnection, CFSTR("CIGaussianBlur"),
- &filter) == kCGErrorSuccess) {
- NSDictionary* blurOptions =
- [NSDictionary dictionaryWithObject:[NSNumber numberWithFloat:1.5]
- forKey:@"inputRadius"];
-
- if (CGSSetCIFilterValuesFromDictionary(cgsConnection, filter,
- base::mac::NSToCFCast(blurOptions)) == kCGErrorSuccess) {
- CGSAddWindowFilter(cgsConnection, [self windowNumber], filter, 1);
- }
-
- CGSReleaseCIFilter(cgsConnection, filter);
- }
- }
-
// Apply animations to show and move self.
[NSAnimationContext beginGrouping];
// The star currently triggers on mouse down, not mouse up.
« no previous file with comments | « chrome/browser/ui/cocoa/info_bubble_window.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698