Record the first recorded entropy source instead of the last.

Record the first recorded entropy source instead of the last.

BUG=None
TEST=No user-visible changes.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152212

[SteveT, 2012-08-17 17:38:18]

Hey Mark,

Here is the change you suggested, implemented verbatim. However, after writing
this, I was beginning to wonder if the first entropy source we return should be
the one we return all the time... That seems to be the spirit of your
suggestion, and I can't think of anything wrong about that (it at least
guarantees us more consistency).

Thoughts?


Steve

[Mark P, 2012-08-17 17:42:38]

lgtm

See comment below.

On 2012/08/17 17:38:18, SteveT wrote:
> Hey Mark,
> 
> Here is the change you suggested, implemented verbatim. However, after writing
> this, I was beginning to wonder if the first entropy source we return should
be
> the one we return all the time... That seems to be the spirit of your
> suggestion, and I can't think of anything wrong about that (it at least
> guarantees us more consistency).
> 
> Thoughts?

Sounds good to me.  I have no objections to adding DCHECKS in that that the
entropy source we're returning is the same as the entropy_source_returned_ in
the past.

--mark

[SteveT, 2012-08-17 18:46:12]

That DCHECK compromise sounds good. Uploaded a new patchset with this change.
Let me know what you think.

[Mark P, 2012-08-17 18:55:53]

On 2012/08/17 18:46:12, SteveT wrote:
> That DCHECK compromise sounds good. Uploaded a new patchset with this change.
> Let me know what you think.

Still lgtm

[commit-bot: I haz the power, 2012-08-17 18:57:30]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[SteveT, 2012-08-17 18:59:59]

Oops, forgot that I need OWNERS approval. Ilya - mind taking a quick look?

[Ilya Sherman, 2012-08-17 19:09:36]

lgtm

[commit-bot: I haz the power, 2012-08-17 19:09:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevet@chromium.org/10832371/4001

[commit-bot: I haz the power, 2012-08-17 21:06:09]

Try job failure for 10832371-4001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-17 21:12:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevet@chromium.org/10832371/4001

[commit-bot: I haz the power, 2012-08-18 01:59:23]

Change committed as 152212