Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2369)

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 10832371: Record the first recorded entropy source instead of the last. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: dchecks Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_service.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service.cc
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc
index b118692cbbfe9e8512c3ab336afb21ac46589f8b..61a42b902936ffaa9f890902f19f7af77a2f4eac 100644
--- a/chrome/browser/metrics/metrics_service.cc
+++ b/chrome/browser/metrics/metrics_service.cc
@@ -549,10 +549,14 @@ std::string MetricsService::GetEntropySource(bool reporting_will_be_enabled) {
// 2) It makes the final entropy source resettable.
std::string low_entropy_source = base::IntToString(GetLowEntropySource());
if (reporting_will_be_enabled) {
- entropy_source_returned_ = LAST_ENTROPY_HIGH;
+ if (entropy_source_returned_ == LAST_ENTROPY_NONE)
+ entropy_source_returned_ = LAST_ENTROPY_HIGH;
+ DCHECK_EQ(LAST_ENTROPY_HIGH, entropy_source_returned_);
return client_id_ + low_entropy_source;
}
- entropy_source_returned_ = LAST_ENTROPY_LOW;
+ if (entropy_source_returned_ == LAST_ENTROPY_NONE)
+ entropy_source_returned_ = LAST_ENTROPY_LOW;
+ DCHECK_EQ(LAST_ENTROPY_LOW, entropy_source_returned_);
return low_entropy_source;
}
« no previous file with comments | « chrome/browser/metrics/metrics_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698