Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10832360: Change to address default selection of menu item (Closed)

Created:
8 years, 4 months ago by Harry McCleave
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, mihaip-chromium-reviews_chromium.org, Aaron Boodman
Visibility:
Public.

Description

Change to address default selection of menu item BUG=142992 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152943

Patch Set 1 #

Patch Set 2 : formalities #

Patch Set 3 : rebase #

Total comments: 4

Patch Set 4 : nit + context state move #

Patch Set 5 : whitespace #

Total comments: 11

Patch Set 6 : moved bound check code #

Patch Set 7 : whitespace #

Total comments: 1

Patch Set 8 : newline #

Patch Set 9 : type check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -12 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_config.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_config.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_config_views.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_controller.h View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 2 3 4 5 6 7 chunks +26 lines, -7 lines 0 comments Download
M ui/views/controls/menu/menu_runner.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_runner.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sky
https://chromiumcodereview.appspot.com/10832360/diff/3001/ui/views/controls/menu/menu_runner.cc File ui/views/controls/menu/menu_runner.cc (right): https://chromiumcodereview.appspot.com/10832360/diff/3001/ui/views/controls/menu/menu_runner.cc#newcode179 ui/views/controls/menu/menu_runner.cc:179: MenuItemView* result = controller->Run(parent, button, menu_, bounds, anchor, Can ...
8 years, 4 months ago (2012-08-20 21:13:48 UTC) #1
Harry McCleave
http://codereview.chromium.org/10832360/diff/3001/ui/views/controls/menu/menu_runner.cc File ui/views/controls/menu/menu_runner.cc (right): http://codereview.chromium.org/10832360/diff/3001/ui/views/controls/menu/menu_runner.cc#newcode179 ui/views/controls/menu/menu_runner.cc:179: MenuItemView* result = controller->Run(parent, button, menu_, bounds, anchor, On ...
8 years, 4 months ago (2012-08-21 01:30:18 UTC) #2
sky
http://codereview.chromium.org/10832360/diff/10001/ui/views/controls/menu/menu_controller.cc File ui/views/controls/menu/menu_controller.cc (right): http://codereview.chromium.org/10832360/diff/10001/ui/views/controls/menu/menu_controller.cc#newcode1557 ui/views/controls/menu/menu_controller.cc:1557: // simply opening the menu (bug 142992) End with ...
8 years, 4 months ago (2012-08-21 15:40:43 UTC) #3
Harry McCleave
http://codereview.chromium.org/10832360/diff/10001/ui/views/controls/menu/menu_controller.cc File ui/views/controls/menu/menu_controller.cc (right): http://codereview.chromium.org/10832360/diff/10001/ui/views/controls/menu/menu_controller.cc#newcode1557 ui/views/controls/menu/menu_controller.cc:1557: // simply opening the menu (bug 142992) On 2012/08/21 ...
8 years, 4 months ago (2012-08-21 18:38:35 UTC) #4
sky
LGTM http://codereview.chromium.org/10832360/diff/2009/ui/views/controls/menu/menu_config.h File ui/views/controls/menu/menu_config.h (right): http://codereview.chromium.org/10832360/diff/2009/ui/views/controls/menu/menu_config.h#newcode114 ui/views/controls/menu/menu_config.h:114: bool offset_context_menus; newline between 114/115.
8 years, 4 months ago (2012-08-21 20:33:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10832360/19001
8 years, 4 months ago (2012-08-22 19:18:43 UTC) #6
commit-bot: I haz the power
Try job failure for 10832360-19001 (retry) on win_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-22 22:51:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10832360/19001
8 years, 4 months ago (2012-08-23 00:03:55 UTC) #8
commit-bot: I haz the power
Try job failure for 10832360-19001 on linux_clang for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=43834 Step "update" is always ...
8 years, 4 months ago (2012-08-23 00:16:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10832360/19001
8 years, 4 months ago (2012-08-23 01:05:31 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-08-23 03:42:15 UTC) #11 
Change committed as 152943

Powered by Google App Engine
This is Rietveld 408576698