Issue 10832334: use type std::string instead of integer for MediaLogEvent::TOTAL_BYTES_SET

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832334: use type std::string instead of integer for MediaLogEvent::TOTAL_BYTES_SET (Closed)

Created:
8 years, 4 months ago by changbin

Modified:
8 years, 4 months ago

Reviewers:
Ami GONE FROM CHROMIUM, scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

use type std::string instead of integer for MediaLogEvent::TOTAL_BYTES_SET because overflow happens for integer larger than 2^31. original review url: http://codereview.chromium.org/10828226 BUG=120328 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151861

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -7 lines)			Patch
M	AUTHORS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/base/media_log.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/base/media_log.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	media/base/pipeline.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

changbin

Sorry to bother. Account mismatch when i commit code from original review url. Therefore, I ...

8 years, 4 months ago (2012-08-16 04:49:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/changbin.shao@intel.com/10832334/1

8 years, 4 months ago (2012-08-16 05:04:41 UTC) #3

Change committed as 151861