media/base/media_log.h - Issue 10832334: use type std::string instead of integer for MediaLogEvent::TOTAL_BYTES_SET

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/media_log.h

Issue 10832334: use type std::string instead of integer for MediaLogEvent::TOTAL_BYTES_SET (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/media_log.h

diff --git a/media/base/media_log.h b/media/base/media_log.h

index 0e93c6b67e41eb3e4a5a50c4371d2b9174df1403..e72c08e5819fe14a304f46441668f7edd0f2762d 100644

--- a/media/base/media_log.h

+++ b/media/base/media_log.h

@@ -31,8 +31,8 @@ class MEDIA_EXPORT MediaLog : public base::RefCountedThreadSafe<MediaLog> {

scoped_ptr<MediaLogEvent> CreateEvent(MediaLogEvent::Type type);

scoped_ptr<MediaLogEvent> CreateBooleanEvent(

MediaLogEvent::Type type, const char* property, bool value);

- scoped_ptr<MediaLogEvent> CreateIntegerEvent(

- MediaLogEvent::Type type, const char* property, int64 value);

+ scoped_ptr<MediaLogEvent> CreateStringEvent(

+ MediaLogEvent::Type type, const char* property, const std::string& value);

scoped_ptr<MediaLogEvent> CreateTimeEvent(

MediaLogEvent::Type type, const char* property, base::TimeDelta value);

scoped_ptr<MediaLogEvent> CreateLoadEvent(const std::string& url);

« no previous file with comments | « AUTHORS ('k') | media/base/media_log.cc » ('j') | no next file with comments »