Issue 10832331: Revert 151829 - Fix gdata includes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832331: Revert 151829 - Fix gdata includes. (Closed)

Created:
8 years, 4 months ago by achuithb

Modified:
8 years, 4 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 151829 - Fix gdata includes. This broke the build. * Remove gdata_files.h from gdata_directory_service.h * Add gdata_files.h where necessary. * Remove unnecessary includes from gdata_directory_service.* and gdata_files.* BUG=140317 TEST=compiles. Review URL: https://chromiumcodereview.appspot.com/10836275 TBR=achuith@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151830

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -42 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_directory_service.h	View	1 chunk	+9 lines, -23 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_directory_service.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_directory_service_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_download_observer.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_files.h	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_files.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_protocol_handler.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_uploader.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_wapi_feed_loader.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_wapi_feed_processor.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages