Issue 10836275: Fix gdata includes.

Issue 10836275: Fix gdata includes. (Closed)

Created:
8 years, 4 months ago by achuithb

Modified:
8 years, 4 months ago

Reviewers:
satorux1

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix gdata includes. * Remove gdata_files.h from gdata_directory_service.h * Add gdata_files.h where necessary. * Remove unnecessary includes from gdata_directory_service.* and gdata_files.* BUG=140317 TEST=compiles. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151829 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151831

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix gdata includes. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -44 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_directory_service.h	View	1 2	1 chunk	+23 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_directory_service.cc	View	1 2	1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_directory_service_unittest.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_download_observer.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_files.h	View	1 2	1 chunk	+0 lines, -19 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_files.cc	View	1 2	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_protocol_handler.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_uploader.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_wapi_feed_loader.h	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_wapi_feed_processor.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/10836275/7001

8 years, 4 months ago (2012-08-16 00:57:21 UTC) #3

achuithb

8 years, 4 months ago (2012-08-16 02:28:16 UTC) #4

Fix gdata includes. 

* Remove gdata_files.h from gdata_directory_service.h
* Add gdata_files.h where necessary.
* Remove unnecessary includes from gdata_directory_service.* and gdata_files.*

BUG=140317
TEST=compiles.

Expand Messages | Collapse Messages