This fixes a problem with the WiFi internet details

This fixes a problem with the WiFi internet details
that I introduced with my last change.

BUG=none
TEST=ran on device and on Linux.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151869

[kevers, 2012-08-15 18:09:25]

LGTM with nit.

http://codereview.chromium.org/10832319/diff/1/chrome/browser/resources/optio...
File chrome/browser/resources/options2/chromeos/internet_detail.js (right):

http://codereview.chromium.org/10832319/diff/1/chrome/browser/resources/optio...
chrome/browser/resources/options2/chromeos/internet_detail.js:769:
inetNameServers = data.ipconfig.value.nameServers;
nit suggestion

Consider reversing the ordering of assignment to simplify the second assignment,
i.e.:

inetNameServers = data.ipconfig.value.nameServers;
$('automatic-dns-display').textContent = inetNameServers;

[Greg Spencer (Chromium), 2012-08-15 18:12:29]

http://codereview.chromium.org/10832319/diff/1/chrome/browser/resources/optio...
File chrome/browser/resources/options2/chromeos/internet_detail.js (right):

http://codereview.chromium.org/10832319/diff/1/chrome/browser/resources/optio...
chrome/browser/resources/options2/chromeos/internet_detail.js:769:
inetNameServers = data.ipconfig.value.nameServers;
On 2012/08/15 18:09:25, kevers wrote:
> nit suggestion
> 
> Consider reversing the ordering of assignment to simplify the second
assignment,
> i.e.:
> 
> inetNameServers = data.ipconfig.value.nameServers;
> $('automatic-dns-display').textContent = inetNameServers;

Done.

[commit-bot: I haz the power, 2012-08-15 18:13:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/10832319/3001

[commit-bot: I haz the power, 2012-08-15 18:13:18]

Presubmit check for 10832319-3001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/resources/options2/chromeos

Presubmit checks took 1.8s to calculate.

[Greg Spencer (Chromium), 2012-08-15 18:15:56]

Dmitry, I would like an OWNERS review for this file.

[Dmitry Polukhin, 2012-08-16 07:05:40]

LGTM

[commit-bot: I haz the power, 2012-08-16 07:06:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/10832319/3001

[commit-bot: I haz the power, 2012-08-16 09:19:49]

Change committed as 151869