Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3419)

Unified Diff: chrome/browser/resources/options2/chromeos/internet_detail.js

Issue 10832319: This fixes a problem with the WiFi internet details (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed nit Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options2/chromeos/internet_detail.js
diff --git a/chrome/browser/resources/options2/chromeos/internet_detail.js b/chrome/browser/resources/options2/chromeos/internet_detail.js
index 7e4d9b45e12d5a76cdbb989f4ec97dd31d27b594..51c28e7f645839706d63df975d5aa9926d44fd8a 100644
--- a/chrome/browser/resources/options2/chromeos/internet_detail.js
+++ b/chrome/browser/resources/options2/chromeos/internet_detail.js
@@ -763,8 +763,11 @@ cr.define('options.internet', function() {
configureAddressField($('ip-netmask'), inetNetmask);
configureAddressField($('ip-gateway'), inetGateway);
- if (data.ipconfig.value && data.ipconfig.value.nameServers)
- $('automatic-dns-display').textContent = data.ipconfig.value.nameServers;
+ var inetNameServers = '';
+ if (data.ipconfig.value && data.ipconfig.value.nameServers) {
+ inetNameServers = data.ipconfig.value.nameServers;
+ $('automatic-dns-display').textContent = inetNameServers;
+ }
if (data.savedIP && data.savedIP.nameServers)
$('automatic-dns-display').textContent = data.savedIP.nameServers;
@@ -812,9 +815,9 @@ cr.define('options.internet', function() {
} else {
$('wifi-bssid-entry').hidden = true;
}
- $('wifi-ip-address').textContent = inetAddress;
- $('wifi-netmask').textContent = inetNetmask;
- $('wifi-gateway').textContent = inetGateway;
+ $('wifi-ip-address').textContent = inetAddress.value;
+ $('wifi-netmask').textContent = inetNetmask.value;
+ $('wifi-gateway').textContent = inetGateway.value;
$('wifi-name-servers').textContent = inetNameServers;
if (data.encryption && data.encryption.length > 0) {
$('wifi-security').textContent = data.encryption;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698