content/renderer/render_view_impl.cc - Issue 10832264: Fix lifecycle-vs-threads of GpuVDAContext3D.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 10832264: Fix lifecycle-vs-threads of GpuVDAContext3D. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: piman CR response Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 005482b9984d3e99f9c2172d07815fc862c2128c..b67d360d21676361b9eb061183c3301c2fe61834 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -2420,10 +2420,10 @@ WebMediaPlayer* RenderViewImpl::createMediaPlayer(

#endif

use_accelerated_video_decode &= !CommandLine::ForCurrentProcess()->HasSwitch(

switches::kDisableAcceleratedVideoDecode);

- base::WeakPtr<WebGraphicsContext3DCommandBufferImpl> context3d =

+ WebGraphicsContext3DCommandBufferImpl* context3d =

use_accelerated_video_decode ?

RenderThreadImpl::current()->GetGpuVDAContext3D() :

- base::WeakPtr<WebGraphicsContext3DCommandBufferImpl>();

+ NULL;

if (context3d) {

MessageLoop* factories_loop =

RenderThreadImpl::current()->compositor_thread() ?