Experimental AutocompleteProvider for zerosuggest.

chrome/browser/autocomplete/zero_suggest_provider.cc

Index: chrome/browser/autocomplete/zero_suggest_provider.cc
diff --git a/chrome/browser/autocomplete/zero_suggest_provider.cc b/chrome/browser/autocomplete/zero_suggest_provider.cc
new file mode 100644
index 0000000000000000000000000000000000000000..0cbb8c9bcf18b3e7016c14858e6d1db29ce3db06
--- /dev/null
+++ b/chrome/browser/autocomplete/zero_suggest_provider.cc
@@ -0,0 +1,220 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/autocomplete/zero_suggest_provider.h"
+
+#include "base/callback.h"
+#include "base/json/json_string_value_serializer.h"
+#include "base/string16.h"
+#include "base/string_util.h"
+#include "base/time.h"
+#include "base/utf_string_conversions.h"
+#include "chrome/browser/autocomplete/autocomplete_input.h"
+#include "chrome/browser/autocomplete/autocomplete_match.h"
+#include "chrome/browser/autocomplete/autocomplete_provider_listener.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/search_engines/template_url_service.h"
+#include "chrome/browser/search_engines/template_url_service_factory.h"
+#include "chrome/common/url_constants.h"
+#include "googleurl/src/gurl.h"
+#include "net/base/load_flags.h"
+#include "net/http/http_response_headers.h"
+#include "net/url_request/url_fetcher.h"
+#include "net/url_request/url_request_status.h"
+
+ZeroSuggestProvider::ZeroSuggestProvider(
+  AutocompleteProviderListener* listener,
+  Profile* profile,
+  const std::string& url_prefix)
+    : AutocompleteProvider(listener, profile, "ZeroSuggest"),
+      url_prefix_(url_prefix),
+      template_url_service_(TemplateURLServiceFactory::GetForProfile(profile)) {
+}
+
+void ZeroSuggestProvider::Start(const AutocompleteInput& input,
+                                bool /*minimal_changes*/) {
+  UpdateMatches(input.text());
+}
+
+void ZeroSuggestProvider::StartZeroSuggest(const GURL& url,
+                                           const string16& user_text) {
+  DCHECK(url.is_valid());
+  // Do not query non-http URLs. There will be no useful suggestions for https
+  // or chrome URLs.
+  if (!url.is_valid() || url.scheme() != chrome::kHttpScheme)

[Peter Kasting, 2012/08/15 21:52:44]

Nit: Remove "!url.is_valid() ||", since we should never handle DCHECK failure.

[Jered, 2012/08/15 23:13:00]

Done.

+    return;
+  matches_.clear();
+  done_ = false;
+  user_text_ = user_text;
+  current_query_ = url.spec();
+  current_query_text_ = ASCIIToUTF16(url.spec());
+  // TODO(jered): Consider adding locally-sourced zero-suggestions here too.
+  // These may be useful on the NTP or more relevant to the user than server
+  // suggestions, if based on local browsing history.
+  Run();
+}
+
+void ZeroSuggestProvider::Stop(bool clear_cached_results) {
+  fetcher_.reset();
+  done_ = true;
+  if (clear_cached_results) {
+    results_.clear();
+    current_query_.clear();
+    current_query_text_.clear();
+  }
+}
+
+void ZeroSuggestProvider::OnURLFetchComplete(const net::URLFetcher* source) {
+  std::string json_data;
+  source->GetResponseAsString(&json_data);
+  const bool request_succeeded =
+      source->GetStatus().is_success() && source->GetResponseCode() == 200;
+
+  bool results_updated = false;
+  if (request_succeeded) {
+    JSONStringValueSerializer deserializer(json_data);
+    deserializer.set_allow_trailing_comma(true);
+    scoped_ptr<Value> data(deserializer.Deserialize(NULL, NULL));
+    results_updated = data.get() && ParseSuggestResults(data.get());
+  }
+  done_ = true;
+
+  ConvertResultsToAutocompleteMatches();
+  if (results_updated)
+    listener_->OnProviderUpdate(results_updated);
+}
+
+ZeroSuggestProvider::~ZeroSuggestProvider() {
+}
+
+void ZeroSuggestProvider::Run() {
+  const int kFetcherID = 1;
+  fetcher_.reset(
+      net::URLFetcher::Create(kFetcherID,
+          GURL(url_prefix_ + current_query_),
+          net::URLFetcher::GET, this));
+  fetcher_->SetRequestContext(profile_->GetRequestContext());
+  fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES);
+  fetcher_->Start();
+}
+
+void ZeroSuggestProvider::UpdateMatches(const string16& user_text) {
+  user_text_ = user_text;
+  const size_t prev_num_matches = matches_.size();
+  ConvertResultsToAutocompleteMatches();
+  if (matches_.size() != prev_num_matches)
+    listener_->OnProviderUpdate(true);
+}
+
+bool ZeroSuggestProvider::ParseSuggestResults(Value* root_val) {
+  std::string query;
+  ListValue* root_list = NULL;
+  ListValue* results = NULL;
+  if (!root_val->GetAsList(&root_list) || !root_list->GetString(0, &query) ||
+      (query != current_query_) || !root_list->GetList(1, &results))
+    return false;
+
+  results_.clear();
+  ListValue* one_result = NULL;
+  for (size_t index = 0; results->GetList(index, &one_result); ++index) {
+    string16 result;
+    one_result->GetString(0, &result);
+    if (result.empty())
+      continue;
+    results_.push_back(result);
+  }
+
+  return true;
+}
+
+void ZeroSuggestProvider::ConvertResultsToAutocompleteMatches() {
+  const TemplateURL* search_provider =
+      template_url_service_->GetDefaultSearchProvider();
+  // Fail if we can't set the clickthrough URL for query suggestions.
+  if (search_provider == NULL || !search_provider->SupportsReplacement())
+    return;
+  matches_.clear();
+  // Do not add anything if there are no results for this URL.
+  if (results_.empty())
+    return;
+  AddMatchForCurrentURL();
+  for (size_t i = 0; i < results_.size(); ++i)
+    AddMatchForResult(search_provider, i, results_[i]);
+}
+
+// TODO(jered): Rip this out once the first match is decoupled from the current
+// typing in the omnibox.
+void ZeroSuggestProvider::AddMatchForCurrentURL() {
+  // If the user has typed something besides the current url, they probably
+  // don't intend to refresh it.
+  const bool user_text_is_url = user_text_ == current_query_text_;
+  if (user_text_.empty() || user_text_is_url) {
+    // The placeholder suggestion for the current URL has high relevance so
+    // that it is in the first suggestion slot and inline autocompleted. It
+    // gets dropped as soon as the user types something.

[Peter Kasting, 2012/08/15 21:52:44]

Nit: Since the zerosuggest provider is the only thing providing results in this
case, you don't actually need 2000/1999 here and below.  You could just have a
single kMaxZeroSuggestRelevance = 100 atop this file, use that here, and
decrement below (based on how many matches are already in the result set, see
next comment).

[Jered, 2012/08/15 23:13:00]

It seems existing providers (e.g. SearchProvider) keep matches_ around so that
they can reuse suggestions when there are minimal changes to omnibox text. With
lower scores, I saw these stale suggestions. To work around that, I've changed
StartZeroSuggest() to expire them immediately, but this doesn't seem to work as
I'd expect. I'll have to dig into this more tomorrow, the code is a bit complex.

[Peter Kasting, 2012/08/16 00:24:41]

I'm not really sure what you're saying here.  The "minimal_changes" flag means
something very specific: the ctrl key state has toggled.  If there's a change
like "the user typed another character", that is not considered a "minimal"
change in the sense that the code understands it.  Maybe that's not what you
meant.

There is a separate caching effect in the SearchProvider specifically that has
to do with results provided by the suggest server, and another in the
AutocompleteController that is related to smoothing out changes while a user
types rapidly.

I don't think I understand the problem you're having to begin with, though.

+    const int kPlaceholderRelevance = 2000;
+    AutocompleteMatch match(this, kPlaceholderRelevance, false,
+                            AutocompleteMatch::NAVSUGGEST);
+    match.destination_url = GURL(current_query_);
+    match.contents = current_query_text_;
+    if (!user_text_is_url) {
+      match.fill_into_edit = current_query_text_;
+      match.inline_autocomplete_offset = 0;
+    }
+    AutocompleteMatch::ClassifyLocationInString(0, current_query_.size(),
+        match.contents.length(), ACMatchClassification::URL,
+        &match.contents_class);
+    matches_.push_back(match);
+  }
+}
+
+void ZeroSuggestProvider::AddMatchForResult(
+    const TemplateURL* search_provider,
+    size_t result_index,
+    const string16& result) {
+  // TODO(jered): Rip out user_text_is_url logic when AddMatchForCurrentURL
+  // goes away.
+  const bool user_text_is_url = user_text_ == current_query_text_;
+  const bool kCaseInsensitve = false;
+  if (!user_text_.empty() && !user_text_is_url &&
+      !StartsWith(result, user_text_, kCaseInsensitve))
+    // This suggestion isn't relevant for the current prefix.
+    return;
+  // This bogus relevance puts suggestions below the placeholder from
+  // AddMatchForCurrentURL(), but very low after the user starts typing so that
+  // zero-suggestions go away after there are other suggestions.
+  // TODO(jered): Use real scores from the suggestion server.
+  const int suggestion_relevance =
+      (user_text_.empty() || user_text_is_url) ? 1999 : 100;

[Peter Kasting, 2012/08/15 21:52:44]

The suggestions we add should not have the same relevance as each other, so that
their sort order is consistent.  This relevance score should decrease as you add
more suggestions.

[Jered, 2012/08/15 23:13:00]

Done.

+  AutocompleteMatch match(this, suggestion_relevance, false,
+      AutocompleteMatch::SEARCH_SUGGEST);
+  match.contents = result;
+  match.fill_into_edit = result;
+  if (!user_text_is_url && user_text_ != result)
+    match.inline_autocomplete_offset = user_text_.length();
+
+  // Build a URL for this query using the default search provider.
+  const TemplateURLRef& search_url = search_provider->url_ref();
+  DCHECK(search_url.SupportsReplacement());
+  match.search_terms_args.reset(
+      new TemplateURLRef::SearchTermsArgs(result));
+  match.search_terms_args->original_query = string16();
+  match.search_terms_args->accepted_suggestion = result_index;
+  match.destination_url =
+      GURL(search_url.ReplaceSearchTerms(*match.search_terms_args.get()));
+
+  if (user_text_.empty() || user_text_is_url || user_text_ == result) {
+    match.contents_class.push_back(
+        ACMatchClassification(0, ACMatchClassification::NONE));
+  } else {
+    // Style to look like normal search suggestions.
+    match.contents_class.push_back(
+       ACMatchClassification(0, ACMatchClassification::DIM));
+    match.contents_class.push_back(
+       ACMatchClassification(user_text_.length(), ACMatchClassification::NONE));
+  }
+  match.transition = content::PAGE_TRANSITION_GENERATED;
+
+  matches_.push_back(match);
+}