Experimental AutocompleteProvider for zerosuggest.

chrome/browser/ui/omnibox/omnibox_edit_model.cc

Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.cc b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
index bf5901d5c47ac8eb5291de1fbe61987dff7a69fa..6e6bd2ec32340f49e2767f6fcde84047bc573093 100644
--- a/chrome/browser/ui/omnibox/omnibox_edit_model.cc
+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
@@ -440,10 +440,12 @@ void OmniboxEditModel::StartAutocomplete(
 }
 
 void OmniboxEditModel::StopAutocomplete() {
-  if (popup_->IsOpen() && !in_revert_) {
-    InstantController* instant = controller_->GetInstant();
-    if (instant && !instant->commit_on_pointer_release())
-      instant->Hide();
+  if (popup_->IsOpen()) {

[Peter Kasting, 2012/08/15 21:52:44]

Nit: Revert remaining change to this function

[Jered, 2012/08/15 23:13:00]

Done.

+    if (!in_revert_) {
+      InstantController* instant = controller_->GetInstant();
+      if (instant && !instant->commit_on_pointer_release())
+        instant->Hide();
+    }
   }
 
   autocomplete_controller_->Stop(true);
@@ -531,9 +533,11 @@ void OmniboxEditModel::OpenMatch(const AutocompleteMatch& match,
         base::TimeTicks::Now() - time_user_first_modified_omnibox_,
         0,  // inline autocomplete length; possibly set later
         result());
-    DCHECK(user_input_in_progress_) << "We didn't get here through the "
-        "expected series of calls.  time_user_first_modified_omnibox_ is "
-        "not set correctly and other things may be wrong.";
+    DCHECK(user_input_in_progress_ ||
+           (match.provider && match.provider->name() == "ZeroSuggest"))

[Peter Kasting, 2012/08/15 21:52:44]

Nit: You don't need "match.provider &&", all matches must have a provider.

[Jered, 2012/08/15 23:13:00]

Done.

+        << "We didn't get here through the expected series of calls. "
+        << "time_user_first_modified_omnibox_ is not set correctly and other "
+        << "things may be wrong.";
     if (index != OmniboxPopupModel::kNoMatch)
       log.selected_index = index;
     else if (!has_temporary_text_)
@@ -695,6 +699,12 @@ void OmniboxEditModel::OnSetFocus(bool control_down) {
   if (instant)
     instant->OnAutocompleteGotFocus();
 
+  // TODO(jered): We may want to merge this into Start() and just call that
+  // here rather than having a special entry point for zero-suggest.

[Peter Kasting, 2012/08/15 21:52:44]

Nit: Might want:

// Note that we avoid PermanentURL() here because it's not guaranteed to give us
the actual underlying current URL, e.g. if we're on the NTP and the
|permanent_text_| is empty.

[Jered, 2012/08/15 23:13:00]

Done.

+  autocomplete_controller_->StartZeroSuggest(
+      controller_->GetTabContents()->web_contents()->GetURL(),
+      user_text_);
+
   NotifySearchTabHelper();
 }
 
@@ -704,6 +714,8 @@ void OmniboxEditModel::OnWillKillFocus(gfx::NativeView view_gaining_focus) {
   if (InstantController* instant = controller_->GetInstant())
     instant->OnAutocompleteLostFocus(view_gaining_focus);
 
+  // TODO(jered): Rip this out along with StartZeroSuggest.
+  autocomplete_controller_->StopZeroSuggest();
   NotifySearchTabHelper();
 }