Issue 10832254: gdata: Remove use of FindEntryByPathSync() from RemoveEntryFromNonRootDirectory()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832254: gdata: Remove use of FindEntryByPathSync() from RemoveEntryFromNonRootDirectory() (Closed)

Created:
8 years, 4 months ago by satorux1

Modified:
8 years, 4 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Remove use of FindEntryByPathSync() from RemoveEntryFromNonRootDirectory() The number of callers of FindEntryByPathSync() is reduced from 9 to 7. BUG=137694, 126634, 139446 TEST=Moving a file to another directory and renaming in the same directory work as before from file manager. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151369

Patch Set 1 #

Patch Set 2 : polish #

Patch Set 3 : just rebase #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -16 lines)			Patch
	M	chrome/browser/chromeos/gdata/gdata_file_system.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View	1 2	1 chunk	+38 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

satorux1

On 2012/08/10 20:43:59, satorux1 wrote: FWIW, I didn't count the number of callers of FindEntryByPathSync() ...

8 years, 4 months ago (2012-08-10 21:02:58 UTC) #2

lgtm.

Expand Messages | Collapse Messages